Add XML sitemap used by robot.txt in market #677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 7975d63 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 8.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 94.1% (-2.3% change). View more on Code Climate. |
|
I am not sure this change is still wanted/needed. First, it points to the old V3 branch, and then, from @kremalicious comment from the market-related PR, it seems that the XML sitemap can be generated from the market alone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fulfilment of mPowered’s DAO, Round 13 relating to search engine optimisations (SEO).
Add a new endpoint
/api/v1/aquarius/assets/sitemapwhich outputs an XML sitemap for use by the market. Takes in one GET parameter,base, which is the base URL for a market (e.g.https://market.oceanprotocol.com)The ES query is just for all assets that are in all mainnet chains and are not in purgatory, sorted by creation date newest to oldest.