Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arweave Integration Milestone 1: Publish using transaction ID #832

Closed

Conversation

MantisClone
Copy link
Contributor

@MantisClone MantisClone commented Jun 20, 2022

Warning
This PR is not meant to be merged. It shows that the Aquarius tests pass when using the provider changes.

Towards oceanprotocol/pm#151.

Changes:

  • Hack CI to use MantisClone/barge repo and arweave-integration branch instead of oceanprotocol/barge

Why no changes to Aquarius?

Arweave integration adds a new file type. but the services[0].files are encrypted by the time Aquarius sees it, and thus no changes are needed.

@MantisClone MantisClone changed the title Hack CI to use MantisClone/barge instead of oceanprotocol/barge Arweave Integration Jun 20, 2022
@MantisClone MantisClone marked this pull request as ready for review June 20, 2022 16:13
@MantisClone MantisClone requested a review from a team as a code owner June 20, 2022 16:13
@codeclimate
Copy link

codeclimate bot commented Jul 27, 2022

Code Climate has analyzed commit f9cbfa6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.2%.

View more on Code Climate.

@MantisClone MantisClone changed the title Arweave Integration Arweave Integration Milestone 1: Publish using transaction ID Aug 7, 2022
@AnaLoznianu
Copy link
Member

Closing this PR as this PR is not meant to be merged. It correctly shows that for the Arweave integration, Aquarius doesn't need any updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants