Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of Concept about using different wallets #139

Closed
aaitor opened this issue May 22, 2019 · 1 comment · Fixed by #176
Assignees
Labels

Comments

@aaitor
Copy link
Contributor

@aaitor aaitor commented May 22, 2019

In order to reduce the friction of users with the Commons Marketplace, it would be necessary to analyze different options to setup alternative wallets integrated into the frontend application.

The analysis resulted could be used to specify a different pattern to integrate about wallet management.

The output of this task should be:

  • Some kind of documentation about the options analyzed
  • A small proof of concept demonstrating an initial integration of the most suitable options
@jernejpregelj

This comment has been minimized.

Copy link
Contributor

@jernejpregelj jernejpregelj commented May 24, 2019

List of tested wallets:

User stages from UI:

To make user flow closer to existing flows in web2.0 we want to move away from multiple stages of web3.0 and present users with familiar login flow.

Current stages of user:

  1. User without web3 support
  2. User with web3 support but not logged in
  3. User with web3 support but not connected to proper network
  4. User with web3 support and logged in

New stages of user:

  1. Not logged in
  2. Logged in

ui-flow

To backup seed phrase from burner wallet we can notify user after he finishes action/gets something of value to wallet.

export-seed

Integration

  • In current integration we have loading script that loads default web3 without wallet and then upgrades to web3 with Metamask wallet if available

  • In branch (https://github.com/oceanprotocol/commons/tree/feature/wallets) is upgraded integration where loading script loads default web3 and after that user can then select BurnerWallet or Metamask to login. Web3 with loaded wallet is then used for Ocean.
    Logging Metamask example
    commons-metamask
    Logging with Burner wallet example
    commons-burnerwallet

  • Current loading script can be replaced by https://github.com/NoahZinsmeister/web3-react package which does exactly the same and has support for more wallets (trezor, ledger). Replacing loading system would require some refactoring. This package is already updated to latest Web3 version we would have to bump versions on squid-js. Prototype create-reac-tapp burnerwallet2.zip
    web3-react-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.