Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet selection #176

Merged
merged 41 commits into from Jul 17, 2019

Conversation

@jernejpregelj
Copy link
Contributor

jernejpregelj commented Jul 9, 2019

Default to burner wallet and allow to switch between burner wallet and MetaMask. Essentially upgrades non-Web3 users into Web3 users. UI flow outlined in #169 (comment).

And more:

  • detect installed market network from Brizo, use it to adapt copy throughout UI
  • improvements to Web3message output, e.g. shown on About page

New default minimal variant of Web3message. Will be appended with warnings if there are any, as seen in extended version further down.

Most of our users will come with non-Web3-capable browsers so this is what they'll see:

Screen Shot 2019-07-11 at 14 55 24

In Web3-capable browsers we show a select wallet action:

Screen Shot 2019-07-10 at 18 37 17

Screen Shot 2019-07-10 at 18 44 42

Wallet selection modal:

Screen Shot 2019-07-10 at 21 23 00

Extended version on About page:

Screen Shot 2019-07-10 at 18 36 12

Screen Shot 2019-07-10 at 20 26 44

Screen Shot 2019-07-10 at 20 24 23

Screen Shot 2019-07-10 at 17 31 13

@jernejpregelj jernejpregelj requested review from oceanprotocol/core-dev as code owners Jul 9, 2019
@kremalicious kremalicious force-pushed the feature/wallets branch 2 times, most recently from 273bc0a to 7dd34e8 Jul 9, 2019
@kremalicious kremalicious changed the title Feature/wallets Wallet selection Jul 9, 2019
@kremalicious kremalicious force-pushed the feature/wallets branch from 7dd34e8 to ad454b9 Jul 9, 2019
@kremalicious

This comment has been minimized.

Copy link
Member

kremalicious commented Jul 9, 2019

@jernejpregelj note: already worked on this and rebased, did some rebase fixes and force pushed. So branch needs to be checked out new from remote

kremalicious and others added 17 commits Jul 9, 2019
…t button
kremalicious and others added 14 commits Jul 11, 2019
@oceanprotocol oceanprotocol deleted a comment Jul 15, 2019
@oceanprotocol oceanprotocol deleted a comment Jul 15, 2019
jernejpregelj and others added 3 commits Jul 16, 2019
@JohnBDB JohnBDB referenced this pull request Jul 16, 2019
5 of 5 tasks complete
Copy link
Member

kremalicious left a comment

Amazing!

giphy-1

@jernejpregelj jernejpregelj merged commit 599e183 into master Jul 17, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@kremalicious kremalicious deleted the feature/wallets branch Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.