New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/erc20enterprise #377
Conversation
|
Still need to write tests just to make sure we have them and coverage is good, but smartcontracts are ready |
|
I think this is a great idea!! Solves a challenging issue for enterprises & token-conservative jurisdictions without breaking the integrity of datatoken concept. And the fact that you went from idea to first-class implementation in days, |
|
@srikanthkaja31 @soonhuat - this solves your requests as well. And cool thing is that you create two active fixedrates for the same asset:
(In order to achieve this, you must set publishMarketFees and consumeMarketFees to zero, and let only swapFees) |
|
As the creator of #365, I can confirm that this addresses my requirements. I'll have to dive a bit deeper to understand it perfectly but for now, we at RPI are stoked to see this land in V4. Thanks, @alexcos20 et al. |
Changes proposed in this PR:
this closes #365, because DT never flows in wallets.
Since the FixedRate and Dispenser have a allowedSwapper set, it means nobody else can get tokens, except the ERC20Enterprise, which has no public buy functions (only buy & use above) -> no one can get tokens in their wallet
Fee structure remains the same. Following fees are allowed:
@trentmc - I need your opinion on this. ^