Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In concepts > quickstart, the ocean.js link goes to API, it should go to ocean.js README #764

Closed
trentmc opened this issue Sep 15, 2021 · 3 comments · Fixed by #768
Closed
Assignees
Labels
Type: Bug Something isn't working

Comments

@trentmc
Copy link
Member

trentmc commented Sep 15, 2021

Describe the bug

To reproduce:

  1. Go to https://docs.oceanprotocol.com/concepts/quickstart/
  2. Click on "ocean.js"
  3. It takes you to to https://docs.oceanprotocol.com/references/ocean.js/

(3) is wrong because that's not a quickstart, it's an API reference (not the best thing to quickly gets started with).

Also: there's a link to React quickstart. That's no longer supported, so we should remove it.

Expected behavior
Step (3) should take you to https://github.com/oceanprotocol/ocean.js/blob/main/README.md

Also: there should be no link to React at all.

@trentmc trentmc added the Type: Bug Something isn't working label Sep 15, 2021
@akshay-ap
Copy link
Collaborator

The quickstart page also refers to Ocean React which is now deprecated. I think we should remove the Ocean React reference.

@trentmc
Copy link
Member Author

trentmc commented Sep 17, 2021

I think we should remove the Ocean React reference.

Agreed. Go ahead and remove it here. I will update this issue's description to be in line with that, so you can have it all in one PR

@akshay-ap
Copy link
Collaborator

I think we should remove the Ocean React reference.

Agreed. Go ahead and remove it here. I will update this issue's description to be in line with that, so you can have it all in one PR

done

trentmc added a commit that referenced this issue Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants