Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arweave file type to DDO spec #1019

Closed
wants to merge 34 commits into from
Closed

Add arweave file type to DDO spec #1019

wants to merge 34 commits into from

Conversation

MantisClone
Copy link

@MantisClone MantisClone commented Jun 17, 2022 •
edited

Towards oceanprotocol/pm#151.

Changes proposed in this PR:

  • Update DDO spec to include arweave file type
  • Generalize file object: "value" key instead of "url", "hash", "transactionId" keys

@netlify
Copy link

netlify bot commented Jun 17, 2022 •
edited

👷 Deploy Preview for docs-oceanprotocol processing.

Name Link
🔨 Latest commit 4002993
🔍 Latest deploy log https://app.netlify.com/sites/docs-oceanprotocol/deploys/62e2c5003b8d24000927452d

@MantisClone
Copy link
Author

The CI checks are failing and I don't know why. I reverted my changes (18a9b51) and the CI checks still fail, so I know that the issue exists without my changes.

@MantisClone MantisClone marked this pull request as ready for review June 19, 2022 12:02
@kremalicious
Copy link
Contributor

repo was unmaintained and nobody dealt with failing CI as it looks like. Just fixed the CI runs in #1030 so after merge or base against main, this PR should get green checks again.

@MantisClone
Copy link
Author

repo was unmaintained and nobody dealt with failing CI as it looks like. Just fixed the CI runs in #1030 so after merge or base against main, this PR should get green checks again.

Thanks for fixing the checks!

@MantisClone MantisClone mentioned this pull request Jun 22, 2022
Merged
@MantisClone MantisClone mentioned this pull request Jun 23, 2022
Closed
@MantisClone MantisClone mentioned this pull request Jun 24, 2022
Closed
@AnaLoznianu AnaLoznianu added this to In Progress in Project Management Jun 28, 2022
@dependabot
Bump eslint-plugin-prettier from 4.0.0 to 4.2.1 (oceanprotocol#1044)
67f62bd 
Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from 4.0.0 to 4.2.1.
- [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md)
- [Commits](prettier/eslint-plugin-prettier@v4.0.0...v4.2.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jamiehewitt15
jamiehewitt15 requested changes Jul 6, 2022
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MantisClone If you want this to be merged at some point it needs to be done into the issue-1039-gitbook-migration branch as that will become main when we migrate to gitbook

Project Management automation moved this from In Progress to Ready for Review Jul 6, 2022
@codeclimate
Copy link

codeclimate bot commented Jul 28, 2022

Code Climate has analyzed commit 4fc5d6d and detected 0 issues on this pull request.

View more on Code Climate.

@MantisClone
Copy link
Author

@jamiehewitt15 I missed your previous message. Thanks for the head's up. I'll update this PR.

@MantisClone MantisClone changed the base branch from main to issue-1039-gitbook-migration July 28, 2022 14:09
@MantisClone
Copy link
Author

Fixing the Files section of the docs took me a lot longer than I thought it would 🤦 but I think it's finally ready.

Here's a screenshot of the Supported storage objects table, just to prove to myself that it's working.
Screenshot from 2022-07-28 13-16-25

@MantisClone
Copy link
Author

I decided to close this PR and open a new one: #1082.

This PR ended up with a bunch of changes that I don't know how to revert cleanly.

Project Management automation moved this from Ready for Review to Done Jul 28, 2022
@MantisClone MantisClone mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kremalicious kremalicious

@mihaisc mihaisc

@alexcos20 alexcos20

@jamiehewitt15 jamiehewitt15

Assignees
No one assigned
Labels
Status: DoNotMerge
Projects
Project Management
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@MantisClone @kremalicious @alexcos20 @jamiehewitt15 @mihaisc @akshay-ap @AnaLoznianu