Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 NFT docs #780

Merged
merged 31 commits into from Feb 21, 2022
Merged

v4 NFT docs #780

merged 31 commits into from Feb 21, 2022

Conversation

akshay-ap
Copy link
Collaborator

@akshay-ap akshay-ap commented Sep 28, 2021

Fixes #781

Changes proposed in this PR:

  • Create an introductory page for NFT + v4
  • Create a roles page

@netlify
Copy link

netlify bot commented Sep 28, 2021

✔️ Deploy Preview for docs-oceanprotocol ready!

🔨 Explore the source changes: 736ed5d

🔍 Inspect the deploy log: https://app.netlify.com/sites/docs-oceanprotocol/deploys/62138cfd276b6a000860446b

😎 Browse the preview: https://deploy-preview-780--docs-oceanprotocol.netlify.app

@akshay-ap
Copy link
Collaborator Author

akshay-ap commented Sep 28, 2021

@akshay-ap
Copy link
Collaborator Author

akshay-ap commented Sep 28, 2021

@kremalicious kremalicious marked this pull request as draft September 29, 2021 11:14
@kremalicious kremalicious added this to the V4 milestone Sep 29, 2021
@codeclimate
Copy link

codeclimate bot commented Nov 9, 2021

Code Climate has analyzed commit 4c14b0f and detected 0 issues on this pull request.

View more on Code Climate.

@kremalicious kremalicious changed the title Issue 701 create v4 docs v4 NFT docs Nov 9, 2021
@kremalicious kremalicious changed the base branch from main to v4 November 9, 2021 09:48
@kremalicious kremalicious mentioned this pull request Nov 9, 2021
Closed
@kremalicious
Copy link
Contributor

Some quotes from various meetings describing the relationship between NFT & datokens we might want to use in here.

@trentmc correct me if I'm wrong with the following blurbs but trying to get the very dry language of this doc draft introducing new terms into something easily readable and understandable. We now have the challenge that people got used to having the datatoken, and its symbol, as the (unique, not technically but de facto) representation for each asset. Rugpullindex & Alga app as case in point. So we need to make the relationship between a newly introduced token now actually uniquely representing the dataset really clear as quickly outlined here.

Data NFTs represent the intellectual property over an asset, while datatokens attached to asset services define and allow access to the asset.

While the NFT could be traded outside of Ocean Market and therefore itself being priced, the actual asset price for download/compute continues to be defined by an attached datatoken/OCEAN pool for pool assets.

The NFT represents the ownership over an asset, whoever has the NFT of an asset owns it in the blockchain sense and in most Ocean dApps will be detected as the publisher. Lawyers won't like this statement. The owner is able to define various roles within the NFT, allowing to delegate actions like updating metadata to managers.

Datatokens define the access to an asset, whoever has a datatoken can download or start a compute job on an asset. They are bound to download or compute services defined and stored within the DDO. As there can be multiple services for an asset, there can be multiple datatokens for an asset, and ultimately multiple pools for an asset. The Ocean Market UI allows only one service and one pool per asset in its first release, but forks are free to extend on that.

@kremalicious
Copy link
Contributor

kremalicious commented Nov 11, 2021

  • mention datatoken name & symbol generation (will stay as is)
  • mention NFT name & symbol generation (needs a new concept first)
  • mention how we store and display asset metadata, and NFT token metadata (needs concept first, see Data NFT market#944)

Copy link
Member

@trentmc trentmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @akshay-ap, sorry for the delay, I've now reviewed and suggested edits. Thanks!

content/concepts/architecture.md Outdated Show resolved Hide resolved
content/concepts/architecture.md Outdated Show resolved Hide resolved
content/concepts/architecture.md Outdated Show resolved Hide resolved
content/concepts/architecture.md Outdated Show resolved Hide resolved
content/concepts/architecture.md Outdated Show resolved Hide resolved
content/concepts/architecture.md Outdated Show resolved Hide resolved
content/concepts/architecture.md Show resolved Hide resolved
content/concepts/data-nft.md Outdated Show resolved Hide resolved
content/concepts/data-nft.md Outdated Show resolved Hide resolved
content/concepts/data-nft.md Outdated Show resolved Hide resolved
@akshay-ap akshay-ap marked this pull request as ready for review February 21, 2022 13:03
@akshay-ap akshay-ap merged commit cc53a21 into v4 Feb 21, 2022
7 checks passed
@akshay-ap akshay-ap deleted the issue-701-create-v4-docs branch February 21, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create v4 NFT docs
3 participants