Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Encoding issue in categories and tags #231

Closed
corrie-sloot opened this issue Nov 8, 2020 · 0 comments · Fixed by #368
Closed

URL Encoding issue in categories and tags #231

corrie-sloot opened this issue Nov 8, 2020 · 0 comments · Fixed by #368
Labels
Priority: High Type: Bug Something isn't working

Comments

@corrie-sloot
Copy link
Contributor

If a tag or category for an asset contains an ampersand (&), when creating links in the market, characters needs to be url encoded.

For example, in Rinkeby Test Network:
https://market.oceanprotocol.com/asset/did:op:46D82feFC506eDD1831c11EA91fA3149179c4465

The category is "Agriculture & Bio Engineering", but if you click on the category near the top, you are redirected to:
https://market.oceanprotocol.com/search?categories=Agriculture%20&%20Bio%20Engineering
instead of
https://market.oceanprotocol.com/search?categories=Agriculture%20%26%20Bio%20Engineering
leading to different results.

Same thing with the tags field.

Other characters may need to be encoded as well.

@kremalicious kremalicious added the Type: Bug Something isn't working label Nov 9, 2020
@trentmc trentmc added this to the V3.x milestone Nov 24, 2020
@kremalicious kremalicious removed this from the V3.x milestone Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants