Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arweave Integration Milestone 1: Publish using transaction ID #1527

Closed
wants to merge 16 commits into from

Conversation

MantisClone
Copy link

@MantisClone MantisClone commented Jun 20, 2022

Towards oceanprotocol/pm#151.

Changes proposed in this PR:

  • Add transactionId field

Note
This does not include the ability to upload to Arweave. That is left for a future PR.

@vercel
Copy link

vercel bot commented Jun 20, 2022

@MantisClone is attempting to deploy a commit to the Ocean Protocol Team on Vercel.

A member of the Team first needs to authorize it.

@MantisClone
Copy link
Author

In oceanprotocol/pm#151 I proposed a Publish UI like the image below. But when I dug into the code, I couldn't find an existing component like this, so I used a boxSelection instead.

Proposed:
image

Approximate Implementation (still work in progress):
Screenshot from 2022-06-21 08-47-48

@kremalicious
Copy link
Contributor

kremalicious commented Jun 21, 2022

this needs design work first. Existing components are not fit for any of this. This can't be dealt with as an isolated thing, as first we need a UI pattern for adding multiple types of file storages, no matter what type. Then in that UI new pattern, add Arweave.

As a first thought, the form elements need to be switched depending on which file storage type is selected. Using the same elements we use for URLs is not going to work out

@MantisClone
Copy link
Author

MantisClone commented Jun 21, 2022

this needs design work first. Existing components are not fit for any of this. This can't be dealt with as an isolated thing, as first we need a UI pattern for adding multiple types of file storages

Can you put this in terms of deliverables? How do you want the design to be expressed?

first we need a UI pattern for adding multiple types of file storages.

I believe adding multiple types of file storage for a single asset is out of scope for this work. The current UI supports a single type of file storage for a single asset, and the proposed design doesn't change that. The type is either a URL or Arweave.

I recognize that the old Ocean Commons screenshot I was using did not make this clear. The differentiation between multiple file types and a single file type didn't coalesce in my mind until yesterday when I actually started editing the code.

As a first thought, the form elements need to be switched depending on which file storage type is selected.

Agreed. When "Arweave" file type is selected. The Transaction ID field is shown. When the URL file type is selected, the File (URL) field is shown.

@kremalicious
Copy link
Contributor

kremalicious commented Jun 21, 2022

sorry, wasn't clear enough. I meant multiple types of file storages for the publish form, I did not mean to imply that one asset can have multiple files which are then from multiple file locations. We are talking UI design here, and just listing all possible storage type options with all their attached input fields at once is the worst option. In the Commons screenshot as an example all actions were opening different sets of input fields, as different file storage types require different user input.

So we need a concept what gets clicked, which fields get revealed and so on. And on top of that make it look good.

@MantisClone
Copy link
Author

Note to self: When updating the FileItem interface, reference this comment thread: oceanprotocol/docs#1019 (comment)

@MantisClone
Copy link
Author

@kremalicious @mihaisc
I have prepared a rough Figma mockup of how I think the publish screen would look when publishing an asset that is stored in Arweave. Can you please take a look at let me know what you think?

https://www.figma.com/file/HT1h5yNiQs8yVTGv7TAu8j/Figma-to-HTML%2C-CSS%2C-React-%26-more!-(Community)?node-id=0%3A1

Basically, when the "Arweave" storage type is selected, the "File" field turns into the "Transaction ID" field.

@MantisClone
Copy link
Author

Here's a quick video of what the latest changes look like: https://user-images.githubusercontent.com/2530913/181637257-2f134e62-490e-486c-910f-3c69fc2a0ce5.mp4

It shows me switching between the URL and Arweave storage types. It also shows that switching between Download and Compute doesn't affect the storage type selection.

@MantisClone MantisClone changed the title Arweave Integration Arweave Integration Milestone 1: Publish using transaction ID Aug 7, 2022
@MantisClone
Copy link
Author

MantisClone commented Oct 1, 2022

After the most recent merge, FileInfo moved inside ocean.js, so this PR now relies on oceanprotocol/ocean.js#1618

EDIT: Nevermind, I realized I didn't need to change FileInfo so I closed oceanprotocol/ocean.js#1618

@netlify
Copy link

netlify bot commented Oct 7, 2022

👷 Deploy request for market-oceanprotocol pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8c246c5

@MantisClone
Copy link
Author

@alexcos20 told me yesterday at the Core Tech WG meeting that there was little to no appetite from the core team to merge this PR. Therefore, I am abandoning it.

@MantisClone MantisClone deleted the arweave-integration branch November 14, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants