New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arweave Integration Milestone 1: Publish using transaction ID #1527
Conversation
|
@MantisClone is attempting to deploy a commit to the Ocean Protocol Team on Vercel. A member of the Team first needs to authorize it. |
|
In oceanprotocol/pm#151 I proposed a Publish UI like the image below. But when I dug into the code, I couldn't find an existing component like this, so I used a |
|
this needs design work first. Existing components are not fit for any of this. This can't be dealt with as an isolated thing, as first we need a UI pattern for adding multiple types of file storages, no matter what type. Then in that UI new pattern, add Arweave. As a first thought, the form elements need to be switched depending on which file storage type is selected. Using the same elements we use for URLs is not going to work out |
Can you put this in terms of deliverables? How do you want the design to be expressed?
I believe adding multiple types of file storage for a single asset is out of scope for this work. The current UI supports a single type of file storage for a single asset, and the proposed design doesn't change that. The type is either a URL or Arweave. I recognize that the old Ocean Commons screenshot I was using did not make this clear. The differentiation between multiple file types and a single file type didn't coalesce in my mind until yesterday when I actually started editing the code.
Agreed. When "Arweave" file type is selected. The Transaction ID field is shown. When the URL file type is selected, the File (URL) field is shown. |
|
sorry, wasn't clear enough. I meant multiple types of file storages for the publish form, I did not mean to imply that one asset can have multiple files which are then from multiple file locations. We are talking UI design here, and just listing all possible storage type options with all their attached input fields at once is the worst option. In the Commons screenshot as an example all actions were opening different sets of input fields, as different file storage types require different user input. So we need a concept what gets clicked, which fields get revealed and so on. And on top of that make it look good. |
|
Note to self: When updating the |
|
@kremalicious @mihaisc Basically, when the "Arweave" storage type is selected, the "File" field turns into the "Transaction ID" field. |
|
Here's a quick video of what the latest changes look like: https://user-images.githubusercontent.com/2530913/181637257-2f134e62-490e-486c-910f-3c69fc2a0ce5.mp4 It shows me switching between the URL and Arweave storage types. It also shows that switching between Download and Compute doesn't affect the storage type selection. |
|
After the most recent merge, EDIT: Nevermind, I realized I didn't need to change |
|
| Name | Link |
|---|---|
| 8c246c5 |
|
@alexcos20 told me yesterday at the Core Tech WG meeting that there was little to no appetite from the core team to merge this PR. Therefore, I am abandoning it. |


Towards oceanprotocol/pm#151.
Changes proposed in this PR: