Pass UrlFile object to Provider.checkFileUrl instead of string

[MantisClone]

Changes proposed in this PR:

• Pass UrlFile object to Provider.checkFileUrl instead of a string

Depends on oceanprotocol/ocean.js#1627

Reasoning:

This is an incremental step towards supporting other file storage types like Arweave, Filecoin, etc...

[netlify]

👷 Deploy request for market-oceanprotocol pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	d87b2e4

[vercel]

@MantisClone is attempting to deploy a commit to the Ocean Protocol Team on Vercel.

A member of the Team first needs to authorize it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
market	❌ Failed (Inspect)		Oct 19, 2022 at 3:42PM (UTC)

[MantisClone]

Hello, @kremalicious Thanks for taking a look at this and approving the CI checks to run. I believe the CI checks are failing because this PR depends on oceanprotocol/ocean.js#1627 which has not yet been merged/released.

[MantisClone]

Hello @alexcos20 @kremalicious @mihaisc @bogdanfazakas

This PR depends on oceanprotocol/ocean.js#1627, but other than that, I think it is ready for review.

[kremalicious]

Misses one more usage of that file check, be sure to handle this for publish preview & published asset which is what the condition for fileInfoResponse in here is for:

market/src/components/Asset/AssetActions/index.tsx

Lines 44 to 82 in 83d8344

	// Get and set file info
	useEffect(() => {
	const oceanConfig = getOceanConfig(asset?.chainId)
	if (!oceanConfig) return
	async function initFileInfo() {
	setFileIsLoading(true)
	const providerUrl =
	formikState?.values?.services[0].providerUrl.url ||
	asset?.services[0]?.serviceEndpoint
	try {
	const fileInfoResponse = formikState?.values?.services?.[0].files?.[0]
	.url
	? await getFileUrlInfo(
	formikState?.values?.services?.[0].files?.[0].url,
	providerUrl
	)
	: await getFileDidInfo(asset?.id, asset?.services[0]?.id, providerUrl)
	fileInfoResponse && setFileMetadata(fileInfoResponse[0])
	// set the content type in the Dataset Schema
	const datasetSchema = document.scripts?.namedItem('datasetSchema')
	if (datasetSchema) {
	const datasetSchemaJSON = JSON.parse(datasetSchema.innerText)
	if (datasetSchemaJSON?.distribution[0]['@type'] === 'DataDownload') {
	const contentType = fileInfoResponse[0]?.contentType
	datasetSchemaJSON.distribution[0].encodingFormat = contentType
	datasetSchema.innerText = JSON.stringify(datasetSchemaJSON)
	}
	}
	setFileIsLoading(false)
	} catch (error) {
	LoggerInstance.error(error.message)
	}
	}
	initFileInfo()
	}, [asset, isMounted, newCancelToken, formikState?.values?.services])

[kremalicious]

ocean.js v2.3.0 has the changes required for this PR

[MantisClone]

Misses one more usage of that file check, be sure to handle this for publish preview & published asset which is what the condition for fileInfoResponse in here is for:

market/src/components/Asset/AssetActions/index.tsx

Lines 44 to 82 in 83d8344

	// Get and set file info
	useEffect(() => {
	const oceanConfig = getOceanConfig(asset?.chainId)
	if (!oceanConfig) return
	async function initFileInfo() {
	setFileIsLoading(true)
	const providerUrl =
	formikState?.values?.services[0].providerUrl.url ||
	asset?.services[0]?.serviceEndpoint
	try {
	const fileInfoResponse = formikState?.values?.services?.[0].files?.[0]
	.url
	? await getFileUrlInfo(
	formikState?.values?.services?.[0].files?.[0].url,
	providerUrl
	)
	: await getFileDidInfo(asset?.id, asset?.services[0]?.id, providerUrl)
	fileInfoResponse && setFileMetadata(fileInfoResponse[0])
	// set the content type in the Dataset Schema
	const datasetSchema = document.scripts?.namedItem('datasetSchema')
	if (datasetSchema) {
	const datasetSchemaJSON = JSON.parse(datasetSchema.innerText)
	if (datasetSchemaJSON?.distribution[0]['@type'] === 'DataDownload') {
	const contentType = fileInfoResponse[0]?.contentType
	datasetSchemaJSON.distribution[0].encodingFormat = contentType
	datasetSchema.innerText = JSON.stringify(datasetSchemaJSON)
	}
	}
	setFileIsLoading(false)
	} catch (error) {
	LoggerInstance.error(error.message)
	}
	}
	initFileInfo()
	}, [asset, isMounted, newCancelToken, formikState?.values?.services])

I looked at this briefly, but I don't know how to fix it.

[kremalicious]

This needs merge or rebase against main and then continue. No need to update ocean.js in here then.

I looked at this briefly, but I don't know how to fix it.

ok, what did you try to solve this? What exactly is unclear?

[kremalicious]

closing as abandoned, and #1765 is picking things up from here.