New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding ipfs / arweave support #1765
adding ipfs / arweave support #1765
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Mmmm... weird Arweave (ignore title, I used an Arweave file here) priced, not ok: |
|
I ran another test published on IPFS and it worked fine this time. I'll let you know if I'm able to reproduce it. |
|
One thing we should do is explain to people how to go about publishing with Arweave or IPFS. I've created an issue for this in the docs. When that's done we should add a link to the docs section in the tooltip. |
|
Also tested publishing a Arweave asset and it worked well It would be great if we could add a test to this to keep the overall test coverage going up. |
We already have a test for both IPFS and Arwaeve. I'm kind of rushing a bit this because I need to keep going with the integration of graphql and on-chain data which depends on this PR. Maybe we can add more tests afterwards. |
Yeah, fair enough. I was just seeing that the overall test coverage is going down. |
|
Why is it only possible to use a URL for the sample file? People may also want to use IPFS/ Arweave for that |
Maybe it'll be implemented in the future, but for this task is out of scope. |
Ok sure, seems fair enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have done quite a few tests now and can't find any faults. Works well, good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of functionality all good from my tests, good job with the PR @EnzoVezzaro
|
Code Climate has analyzed commit d273388 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 18.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 21.4% (-0.1% change). View more on Code Climate. |


Changes proposed in this PR:
@oceanprotocol/lib@2.5.2WIP:
ARWEAVE_GATEWAYdefined error when using Arweave as provider type provider#555 to testARWEAVETO TEST:
Publish
Before validation:

After validation:

Edit
When entered in edit form:

After clicking on "x":
