Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/oceanprotocol/market/55CDSAw3PoxBRWPtCtfQ8NzsPL5v |
|
Hey @kremalicious , though I'll just shoot you a comment here. Thanks for the Rinkeby tokens. I've tried to create the pricing on the pool, however it looks that I'm unable to mint the amount of Data Tokens that I'm looking for. I'll provide upwards of $OCEAN 5000+ initial liquidity at an IDO price of 0.02 - 0.05. So the amount of Data Tokens available will be between 50K - 120K. Is it possible to change this, so I'm able to mint that much? Let me know if you can help us for this. |
|
Change in this PR would be totally fine so far. But the datatoken cap indeed is hardcoded right now, or more precisely the Some options I can think of to make your use case possible in a timely way where we can pick one:
|
c3a64f7 to
ed1b3fb
Compare
|
Hi @kremalicious , thanks a lot for presenting all the options. I’m inclined towards Option 1, as it seems to be the most timely solution. Also I feel Option 2 will be obsolete when v4 launches and since the micro-cap IDO is a trial & error, I don’t want to create too much work for your team. Before going ahead, could you please help to clarify the below for my understanding?
thanks again for helping and supporting 🙏 |
well it just depends on the code change in this PR. I just hardcoded here to So if you now use the preview of this PR everything you publish through it will have this cap. Until we change it in here again. You can see this in the debug output under publish form too: |
|
Well you have to publish a new asset, only that will have the cap hardcoded in here. The cap is set during the datatoken creation which is happening before the price creation. So you can't set it during price creation because the datatoken is already minted. Price creation is creating the pool (or fixed rate exchange), not the datatoken itself. So nothing in the DDO regarding the cap there will be affected by anything you do on that existing asset https://market-git-feature-micro-cap-oceanprotocol.vercel.app/asset/did:op:81DC6629b05F43D522049382a013EB7E2772cC99 Seeing this asset makes me think you might have a flow to publish programmatically already setup (as name & symbol is custom) so would suggest to just continue in that flow and just additionally pass the |
|
Just created the price & supply of 100'000 Data Tokens! Exciting! @kremalicious , please advise how do we go about the custom ticker ? |
to allow this in the UI would be a bit more complex to setup, hardcoding could work but also needs quick investigation as we auto-generate a new one on initial render of form. But we are not going to update it for you for every planned IDO anyway. As I said, ideally you would create the initial asset programmatically which you seem to have done in the past already and would give you all the flexibility you need as the |
|
Hi @kremalicious , appreciate the offer to hardcode it for this one. Once it's done, will I have to create it via the link or will it show up immediately? If this is the case, let's wait until I'm fully ready with the dataset in about 15 days or so. Thanks |
d2c2811 to
cb0a988
Compare
|
Code Climate has analyzed commit cb0a988 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Revisit after v4 |


Uh oh!
There was an error while loading. Please reload this page.