New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arweave Integration Milestone 1: Publish using transaction ID #860
Arweave Integration Milestone 1: Publish using transaction ID #860
Conversation
|
I believe all the changes related to Arweave files are working as intended. All the tests are passing except the polygon config test due to error:
https://github.com/oceanprotocol/ocean.py/runs/6950317363?check_suite_focus=true#step:7:150 I believe this error is unrelated to the Arweave integration changes. |
- Needed because new provider commit
oceanprotocol/provider@e1725c4
- latest provider commit:
oceanprotocol/provider@d1c1f38
- latest provider commit:
oceanprotocol/provider@deb5d69
ImportError while loading conftest '/home/runner/work/ocean.py/ocean.py/conftest.py'.
conftest.py:9: in <module>
from ocean_lib.aquarius.aquarius import Aquarius
ocean_lib/aquarius/__init__.py:6: in <module>
from .aquarius import Aquarius # noqa
ocean_lib/aquarius/aquarius.py:17: in <module>
from ocean_lib.assets.asset import Asset
ocean_lib/assets/asset.py:13: in <module>
from ocean_lib.services.service import Service
ocean_lib/services/service.py:19: in <module>
from ocean_lib.structures.file_objects import FilesType
ocean_lib/structures/file_objects.py:11: in <module>
class FilesType:
ocean_lib/structures/file_objects.py:32: in FilesType
def from_dict(cls, dict: Dict[str, Any]) -> Self:
/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/enforce_typing/decorator.py:8: in enforce_types
spec = inspect.getfullargspec(wrapped)
/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/inspect.py:1144: in getfullargspec
raise TypeError('unsupported callable') from ex
E TypeError: unsupported callable
|
Hi @MantisClone! I've added the reviewers back. I see the tests are failing though, can you please fix them? |
|
Thanks for pointing that out @AnaLoznianu. I believe that I've fixed all the issues now - all the tests pass locally. But i'm having trouble getting the CI checks to pass. I've already spent over 2 hours on it this morning. Each CI run takes over 30 minutes. There are frequent random failures, especially
|
|
Hello @alexcos20 @calina-c @mariacarmina I believe this PR is ready for review. |
|
@alexcos20 @calina-c @mariacarmina CC @AnaLoznianu |
|
@alexcos20 CC @AnaLoznianu |
|
This needs a README to show how to use. It can look similar to:
|
|
Hi @trentmc. Thanks for the comments. This PR has dropped off the end of my priority list and I don't have the bandwidth to continue pushing it forward. I could hand-off this PR to someone on the core team by retargeting it to a development branch on the upstream repo instead of |
Towards oceanprotocol/pm#151.
Changes proposed in this PR
ArweaveFileclass andtest_arweave_file()to test it.get_arweave_file()helper andarweave_filefixture.arweave_filefixture. including:test_encrypt,test_fileinfo,test_initialize,test_consume_flow,test_compute_flow_registered_asset_in_arweave, and all of the tests intest_ocean_assets.pyChanges that were implemented but then reverted
arweavefile type to DDO spec docs#1019 (comment))pytest.ymlto useMantisClone/bargerepo which usesdmats/provider:arweave-integrationdocker image to make the CI tests pass. Reverted now that provider PR Arweave Integration Milestone 1: Publish using transaction ID provider#485 is merged.