Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow the iTunes Search API to sort the results #4

Merged
merged 1 commit into from Feb 4, 2012

Conversation

Projects
None yet
2 participants
Contributor

robottwo commented Jan 6, 2012

No description provided.

Owner

ocelma commented Jan 6, 2012

Thanks!

I will merge it ASAP.

BTW, it'd be nice if you can provide a test for each change you made
(see tests/ folder), that is: offset and order params.

Oscar

On Fri, Jan 6, 2012 at 5:34 AM, robottwo
reply@reply.github.com
wrote:

You can merge this Pull Request by running:

 git pull https://github.com/robottwo/python-itunes 6d0f9db

Or you can view, comment on it, or merge it online at:

 #4

-- Commit Summary --

  • Added a sort option and an app search helper function.

-- File Changes --

M itunes/init.py (34)

-- Patch Links --

 https://github.com/ocelma/python-itunes/pull/4.patch
 https://github.com/ocelma/python-itunes/pull/4.diff


Reply to this email directly or view it on GitHub:
#4

Contributor

robottwo commented Jan 6, 2012

Great -- oh, I didn't notice the tests/ directory. I'll do that
going forward.

Great module, btw. Saved me lots of time!

Thanks,

-Dan

On Fri, 6 Jan 2012 06:28:11 -0800, Oscar Celma wrote:

Thanks!

I will merge it ASAP.

BTW, it'd be nice if you can
provide a test for each change you made
(see tests/ folder), that is:
offset and order params.

Oscar

On Fri, Jan 6, 2012 at 5:34 AM,
robottwo

wrote:

You can merge this Pull Request by running:
git pull https://github.com/robottwo/python-itunes [1]
6d0f9db Or you can view, comment on it,
or merge it online at: #4
[2] -- Commit Summary -- * Added a sort option and an app search helper
function. -- File Changes -- M itunes/init.py (34) -- Patch Links --
https://github.com/ocelma/python-itunes/pull/4.patch [3]
https://github.com/ocelma/python-itunes/pull/4.diff [4] --- Reply to
this email directly or view it on GitHub:
#4 [5]


Reply to
this email directly or view it on GitHub:

#4 (comment)
[7]

Links:

[1] https://github.com/robottwo/python-itunes
[2]
#4
[3]
https://github.com/ocelma/python-itunes/pull/4.patch
[4]
https://github.com/ocelma/python-itunes/pull/4.diff
[5]
#4
[6]
mailto:reply@reply.github.com
[7]
#4 (comment)

@ocelma ocelma merged commit 6d0f9db into ocelma:master Feb 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment