From 2a9ec4ea8bbf5c985db655bf1e0c7fedf0214b48 Mon Sep 17 00:00:00 2001 From: Diego Hurtado Date: Thu, 16 Jul 2020 18:47:56 -0600 Subject: [PATCH] Revert "Implement get_attribute and set_attribute" This reverts commit de3417252cea82f089e49bd681c35dff07463222. --- opentelemetry-api/src/opentelemetry/trace/span.py | 10 ---------- .../src/opentelemetry/sdk/trace/__init__.py | 4 ---- 2 files changed, 14 deletions(-) diff --git a/opentelemetry-api/src/opentelemetry/trace/span.py b/opentelemetry-api/src/opentelemetry/trace/span.py index c45f92a4e2c..d207ecf565b 100644 --- a/opentelemetry-api/src/opentelemetry/trace/span.py +++ b/opentelemetry-api/src/opentelemetry/trace/span.py @@ -37,13 +37,6 @@ def set_attribute(self, key: str, value: types.AttributeValue) -> None: Sets a single Attribute with the key and value passed as arguments. """ - @abc.abstractmethod - def get_attribute(self, key: str) -> types.AttributeValue: - """Gets an Attribute. - - Gets a single Attribute with the key passed as argument. - """ - @abc.abstractmethod def add_event( self, @@ -242,9 +235,6 @@ def end(self, end_time: typing.Optional[int] = None) -> None: def set_attribute(self, key: str, value: types.AttributeValue) -> None: pass - def get_attribute(self, key: str) -> types.AttributeValue: - pass - def add_event( self, name: str, diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py index f83c0c9f775..b76ba49ad4a 100644 --- a/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py +++ b/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py @@ -553,10 +553,6 @@ def set_attribute(self, key: str, value: types.AttributeValue) -> None: with self._lock: self.attributes[key] = value - def get_attribute(self, key: str) -> types.AttributeValue: - - return self.attributes[key] - @staticmethod def _filter_attribute_values(attributes: types.Attributes): if attributes: