New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse update manifests if the response is a string #48

Merged
merged 1 commit into from Nov 26, 2018

Conversation

Projects
None yet
3 participants
@pimterry
Contributor

pimterry commented Nov 26, 2018

This improves compatibility with various non-S3 hosting approaches, including github releases and the azure blob service. Fixes #28.

Parse update manifests if the response is a string
This improves compatibility with various non-S3 hosting approaches,
including github releases and the azure blob service.
@salesforce-cla

This comment has been minimized.

salesforce-cla bot commented Nov 26, 2018

Thanks for the contribution! Before we can merge this, we need @pimterry to sign the Salesforce.com Contributor License Agreement.

@jdxcode jdxcode merged commit 757b5a5 into oclif:master Nov 26, 2018

2 checks passed

salesforce-cla All contributors have signed the CLA
Details
security/snyk - package.json (jdxcode) No manifest changes detected

oclif-bot added a commit that referenced this pull request Nov 26, 2018

chore(release): 1.3.8 [skip ci]
## [1.3.8](v1.3.7...v1.3.8) (2018-11-26)

### Bug Fixes

* Parse update manifests if the response is a string ([#48](#48)) ([757b5a5](757b5a5))
@oclif-bot

This comment has been minimized.

Contributor

oclif-bot commented Nov 26, 2018

🎉 This PR is included in version 1.3.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jdxcode

This comment has been minimized.

Contributor

jdxcode commented Nov 26, 2018

I clarified the comment a bit because s3 doesn't do anything automatic either, we manually set the content-type for s3

@pimterry

This comment has been minimized.

Contributor

pimterry commented Nov 26, 2018

Amazing, thanks!

@pimterry pimterry deleted the httptoolkit:parse-manifest branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment