New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spaces and varied case in suppress comments #281

Merged
merged 1 commit into from Jan 16, 2016

Conversation

Projects
None yet
2 participants
@mgrebenets

mgrebenets commented Jan 14, 2016

Official documentation has example of both //!OCLINT and //!OCLint warnings suppress comments.
However, actual implementation supports only //!OCLINT.
A bit confusing, takes a while to figure out that documentation is wrong.

This change will use case-insensitive check for "oclint" match.
Additionally, it allows to have space after //!, e.g. //! OCLINT, which is a valid form of raw comment.

P.S.
Stuff like //! oclint will also work, but it's rather undocumented feature :).

@ryuichis

This comment has been minimized.

Contributor

ryuichis commented Jan 18, 2016

@hastyjw I am removing your comment due to violation to code of conduct. You receive email notifications because you at a certain point of time watched this repo. However, github doesn't grant me the permission to remove you, so please unwatch this repo yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment