Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional cursors added in GLFW are optional and can fail #2980

Closed
Crunkle opened this issue Jan 14, 2020 · 1 comment
Closed

Additional cursors added in GLFW are optional and can fail #2980

Crunkle opened this issue Jan 14, 2020 · 1 comment

Comments

@Crunkle
Copy link
Contributor

@Crunkle Crunkle commented Jan 14, 2020

If the additional cursors used by the GLFW 3.4+ implementation (b5cad20) are not found then GLFW will return an error GLFW_CURSOR_UNAVAILABLE with no pointer. See this fail condition and the supporting GLFW compat docs.

We are using the following three which are not always guaranteed: GLFW_RESIZE_NESW_CURSOR, GLFW_RESIZE_NWSE_CURSOR, and GLFW_NOT_ALLOWED_CURSOR. Similar outcome for Wayland.

I believe there is no current way to request which cursors are available beforehand? I can only think to ignore the error and fallback to the old cursor on failure.

rokups added a commit to rokups/imgui that referenced this issue Jan 14, 2020
rokups added a commit to rokups/imgui that referenced this issue Jan 16, 2020
…to using arrow cursor.

Solves ocornut#2980.
rokups added a commit to rokups/imgui that referenced this issue Jan 16, 2020
…to using arrow cursor.

Solves ocornut#2980.
rokups added a commit to rokups/imgui that referenced this issue Jan 16, 2020
…to using arrow cursor.

Solves ocornut#2980.
ocornut added a commit that referenced this issue Jan 17, 2020
…X11 setups may be missing them + comment (#2980)
@ocornut

This comment has been minimized.

Copy link
Owner

@ocornut ocornut commented Jan 17, 2020

Fixed by aa34681
I initially felt that error report was pretty agressive on GLFW's part, but it's mostly that the behavior isn't ideal in our specific use case (providing a piece of reusable GLFW software). In most real software the user can catch it. I would expect any GLFW application eventually ignoring those because of X11 configurability.

@ocornut ocornut closed this Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.