Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDirectX11: Remove unnecessary device invalidation/creation #2088
+2
−2
Conversation
ice1000
referenced this pull request
Sep 17, 2018
Closed
DirectX11: Any reason for invalidating and creating devices again here? #2086
ocornut
changed the title from
Remove unnecessary device invalidation/creation
to
DirectX11: Remove unnecessary device invalidation/creation
Oct 1, 2018
This comment has been minimized.
This comment has been minimized.
|
Would this apply to DX10? |
ocornut
added
the
backend/binding
label
Oct 4, 2018
This comment has been minimized.
This comment has been minimized.
|
Either me and the guy who points this out don't know about dx10.. |
added a commit
that referenced
this pull request
Oct 5, 2018
This comment has been minimized.
This comment has been minimized.
|
That's applied now. |
ocornut
closed this
Oct 5, 2018
ice1000
deleted the
ice1k:patch-1
branch
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ice1000 commentedSep 17, 2018
#2086