Arabic Support Added #19

Merged
merged 2 commits into from Jun 14, 2012

3 participants

@SabryShawally

Added an Arabic resource bundle, and a corresponding test file.

Signed-off-by: Muhammad Sabry Ali Muhammad_Sabry_Ali@hotmail.com

@abosabry abosabry Added an Arabic resource bundle Resources_ar.java, and a correspondin…
…g test file test/java/org/ocpsoft/prettytime/PrettyTimeI18n_AR_Test.java.

Signed-off-by: Muhammad Sabry Ali <Muhammad_Sabry_Ali@hotmail.com>
72ad5db
@lincolnthree
OCPsoft member

Hi there Muhammad!

This is fantastic! It looks, though, like your test case hasn't been updated for testing the actual arabic time results. I imagine this is an accident? Do you want to update this before I merge in your time bundle?

Thanks!
Lincoln

@SabryShawally

you are right, I could swear I had got it tested, anyway I fixed the test case and pushed it.

@lincolnthree
OCPsoft member

Fantastic! Thank you so much! Would you like to be listed on the website as a contributor?

@lincolnthree lincolnthree merged commit 0296f6f into ocpsoft:master Jun 14, 2012
@SabryShawally

Thanks, I would really appreciate that, and if anything shows up don't hesitate to contact me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment