New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yesterday isn't parsed correctly #65

Merged
merged 1 commit into from Dec 3, 2013

Conversation

Projects
None yet
2 participants
@msvab

msvab commented Nov 29, 2013

Hi,

Using PretyTimeParser.parse("yesterday") gives you back either today or tomorrow. However if you use PrettyTimeParser.parseSyntax("yesterday") you get back the date you would expect.

The issue seems to be with the relativize() logic in parse() method. As I don't know the full picture behind the relativize logic, I didn't really want to change that method, so I'm at least supplying a failing test.

If you can have a look at it, that would be great as I really like using this project!

Cheers,
Michal

@lincolnthree

This comment has been minimized.

Member

lincolnthree commented Dec 3, 2013

Hey Michal,

Thanks for the test case! I'll take a look at this now.

~Lincoln

lincolnthree added a commit that referenced this pull request Dec 3, 2013

Merge pull request #65 from msvab/master
yesterday isn't parsed correctly

@lincolnthree lincolnthree merged commit 3b71714 into ocpsoft:master Dec 3, 2013

@lincolnthree

This comment has been minimized.

Member

lincolnthree commented Dec 3, 2013

Fixed.

lincolnthree added a commit that referenced this pull request Dec 3, 2013

@lincolnthree

This comment has been minimized.

Member

lincolnthree commented Dec 3, 2013

Releasing 3.2.2.Final

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment