New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about Rewrite version to log output - Rewrite starting #129

Closed
452 opened this Issue Sep 18, 2013 · 5 comments

Comments

Projects
None yet
3 participants
@452
Copy link

452 commented Sep 18, 2013

Please add information about Rewrite version to log output when Rewrite is starting

17:37:09,199 INFO [org.ocpsoft.rewrite.faces.RewritePhaseListener] RewritePhaseListener starting up.

17:37:12,487 INFO [org.ocpsoft.rewrite.servlet.RewriteFilter] RewriteFilter starting up...

17:37:13,613 INFO [org.ocpsoft.rewrite.servlet.RewriteFilter] RewriteFilter initialized.


17:37:09,199 INFO [org.ocpsoft.rewrite.Version] Rewrite 2.0.7.Final

like this:
17:36:50,390 INFO [org.jboss.as.connector.deployers.jdbc] JBAS010403: Deploying JDBC-compliant driver class org.h2.Driver (version 1.3)
17:36:50,437 INFO [org.jboss.weld.Version] WELD-000900 1.1.5 (AS71)
17:36:50,712 INFO [org.hibernate.annotations.common.Version] HCANN000001: Hibernate Commons Annotations {4.0.1.Final}
17:36:50,718 INFO [org.hibernate.Version] HHH000412: Hibernate Core {4.0.1.Final}
17:37:11,708 INFO [org.primefaces.webapp.PostConstructApplicationEventListener] Running on PrimeFaces 4.0-SNAPSHOT
17:36:51,724 INFO [org.hibernate.validator.util.Version] Hibernate Validator 4.2.0.Final
17:36:51,992 INFO [org.hibernate.search.Version] HSEARCH000034: Hibernate Search 4.2.0.Final

@chkal

This comment has been minimized.

Copy link
Member

chkal commented Sep 18, 2013

Good idea. +1 for this.

I already did something similar for Togglz. It's easy:

https://github.com/togglz/togglz/blob/master/core/src/main/java/org/togglz/core/Togglz.java#L23

@lincolnthree

This comment has been minimized.

Copy link
Member

lincolnthree commented Sep 18, 2013

Agreed. Let's do this. Great idea!

@chkal

This comment has been minimized.

Copy link
Member

chkal commented Sep 27, 2013

Done. Instead of:

17:37:13,613 INFO [RewriteFilter] RewriteFilter initialized.

You will now get:

17:37:13,613 INFO [RewriteFilter] Rewrite 2.0.8-SNAPSHOT initialized.

@chkal chkal closed this Sep 27, 2013

@452

This comment has been minimized.

Copy link

452 commented Sep 27, 2013

Thanks =)

@lincolnthree

This comment has been minimized.

Copy link
Member

lincolnthree commented Sep 28, 2013

Perfect, Christian! You rock :)

On Fri, Sep 27, 2013 at 11:33 AM, emetemunoy notifications@github.comwrote:

Thanks =)


Reply to this email directly or view it on GitHubhttps://github.com//issues/129#issuecomment-25253986
.

Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment