New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewritten URLs don't contain jsessionid any more if cookies are disabled #147

Closed
chkal opened this Issue Nov 13, 2013 · 8 comments

Comments

Projects
None yet
2 participants
@chkal
Member

chkal commented Nov 13, 2013

It seems like embedding the session id in the URL doesn't work at all for rewritten URLs. I'll create a test case.

chkal added a commit that referenced this issue Nov 13, 2013

@lincolnthree

This comment has been minimized.

Member

lincolnthree commented Nov 13, 2013

Uh oh :p That seems bad.

On Wed, Nov 13, 2013 at 1:52 AM, Christian Kaltepoth <
notifications@github.com> wrote:

It seems like embedding the session id in the URL doesn't work at all for
rewritten URLs. I'll create a test case.


Reply to this email directly or view it on GitHubhttps://github.com//issues/147
.

Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."

@lincolnthree

This comment has been minimized.

Member

lincolnthree commented Nov 13, 2013

Just curious. Is this issue specifically a problem just with the Faces
Integration and JSF, or does it occur when including Servlet on something
like a JSP as well?

On Wed, Nov 13, 2013 at 8:18 AM, Lincoln Baxter, III <
lincolnbaxter@gmail.com> wrote:

Uh oh :p That seems bad.

On Wed, Nov 13, 2013 at 1:52 AM, Christian Kaltepoth <
notifications@github.com> wrote:

It seems like embedding the session id in the URL doesn't work at all for
rewritten URLs. I'll create a test case.


Reply to this email directly or view it on GitHubhttps://github.com//issues/147
.

Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."

Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."

chkal added a commit to chkal/rewrite that referenced this issue Nov 13, 2013

@chkal

This comment has been minimized.

Member

chkal commented Nov 13, 2013

Currently it looks like it only happens for JSF... Investigating...

@chkal

This comment has been minimized.

Member

chkal commented Nov 13, 2013

I think I found the cause for this. I created a pull request to let Travis run all the container tests.

But it seems like my test doesn't run on AS7. Looks like AS7 never adds any jsessionid to URLs. But there is no web.xml which disables URL session tracking mode. Weird. Let's wait for the build.

@lincolnthree

This comment has been minimized.

Member

lincolnthree commented Nov 13, 2013

Ah, gotcha, strange!

On Wed, Nov 13, 2013 at 11:10 AM, Christian Kaltepoth <
notifications@github.com> wrote:

I think I found the cause for this. I created a pull request to let Travis
run all the container tests.

But it seems like my test doesn't run on AS7. Looks like AS7 never adds
any jsessionid to URLs. But there is no web.xml which disables URL session
tracking mode. Weird. Let's wait for the build.


Reply to this email directly or view it on GitHubhttps://github.com//issues/147#issuecomment-28407628
.

Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."

@chkal

This comment has been minimized.

Member

chkal commented Nov 13, 2013

Travis build for the pull request (still running)

https://travis-ci.org/ocpsoft/rewrite/builds/13920392

chkal added a commit that referenced this issue Nov 23, 2013

@chkal

This comment has been minimized.

Member

chkal commented Nov 23, 2013

I merged this now. I know it's not nice to ignore this test for AS7 and GF3, but I really don't know why both don't add jsessionid to the URLs at all. But they don't do this for other tests as well. One of the main difficulties to get our test suite to run on TomEE and GF4 was that many tests started to fail just because of jsessionids that were appended to the URLs.

However, this bug should be fixed now. :)

@chkal chkal closed this Nov 23, 2013

@lincolnthree

This comment has been minimized.

Member

lincolnthree commented Dec 3, 2013

That is very strange. Nice fix btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment