Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.ocpsoft.rewrite.servlet.util.URLBuilder - private String decodeSegment(final String segment) #203

Closed
michelepra opened this issue Mar 4, 2015 · 2 comments

Comments

@michelepra
Copy link

http://www.w3schools.com/tags/ref_urlencode.asp

String prepared = ("http://localhost/" + segment).replaceAll("+", "%20");

the '+' must be replaced with "%2B"

please fix soon this bug.

Thanks

@michelepra michelepra changed the title BUG in org.ocpsoft.rewrite.servlet.util.URLBuilder - private String decodeSegment(final String segment) org.ocpsoft.rewrite.servlet.util.URLBuilder - private String decodeSegment(final String segment) Mar 4, 2015
@chkal chkal closed this as completed in f68857d Mar 4, 2015
@chkal
Copy link
Member

chkal commented Mar 4, 2015

Thanks. Good catch. Not sure why this was added to the code. The class is deprecated anyway and we should get rid of it. ;)

@michelepra
Copy link
Author

Yes but it's currently used in last final release 2.0.12
Let me be crazy this morning to solve this problem.
The only workaround is to clone Join rule that use a clone version of Path condition that don't use URLBuilder internally, horrible but it work :)

Thank you for this fast solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants