Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended AddressBuilder in order to support "Scheme Sepcific Parts". #124

Merged
merged 1 commit into from Sep 15, 2013
Merged

Extended AddressBuilder in order to support "Scheme Sepcific Parts". #124

merged 1 commit into from Sep 15, 2013

Conversation

@fabmars
Copy link
Contributor

@fabmars fabmars commented Aug 15, 2013

Thus, for example, "mailto:" or "tel:"-based URL's are now supported.
See http://en.wikipedia.org/wiki/URI_scheme for a list of possible SSPs.
Added 2 tests for AddressBuilding and result generation.

Thus, for example, "mailto:" or "tel:"-based URL's are now supported.
See http://en.wikipedia.org/wiki/URI_scheme for a list of possible SSPs.
Added 2 tests for AddressBuilding and result generation.
@fabmars
Copy link
Contributor Author

@fabmars fabmars commented Sep 15, 2013

Argh it didn't make it in 2.0.6.Final.

@lincolnthree
Copy link
Member

@lincolnthree lincolnthree commented Sep 15, 2013

Damn! I'll do another release tonight :( Sorry about that Fabien!

On Sun, Sep 15, 2013 at 6:39 PM, Fabien Marsaud notifications@github.comwrote:

Argh it didn't make it in 2.0.6.Final.


Reply to this email directly or view it on GitHubhttps://github.com//pull/124#issuecomment-24482141
.

Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."

lincolnthree added a commit that referenced this pull request Sep 15, 2013
Extended AddressBuilder in order to support "Scheme Sepcific Parts".
@lincolnthree lincolnthree merged commit 067f8f2 into ocpsoft:master Sep 15, 2013
@lincolnthree
Copy link
Member

@lincolnthree lincolnthree commented Sep 16, 2013

Done! Thanks for the reminder :) Busy these days.

@fabmars
Copy link
Contributor Author

@fabmars fabmars commented Sep 19, 2013

It works! Thanks.

@lincolnthree
Copy link
Member

@lincolnthree lincolnthree commented Sep 19, 2013

Great! Awesome :)

On Thu, Sep 19, 2013 at 1:16 PM, Fabien Marsaud notifications@github.comwrote:

It works! Thanks.


Reply to this email directly or view it on GitHubhttps://github.com//pull/124#issuecomment-24756640
.

Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants