Use wildcard type arguments when locating cdi beans

[BrynCooke]

By using a wildcard instead of Object for type parameters the correct beans are found.

[BrynCooke]

Use https://github.com/ocpsoft/rewrite/pull/143/files?w=1 to view changes without whitespace issues.

[BrynCooke]

As discussed in #137

[lincolnthree]

Thanks Bryn!

Hmmmm... Travis says the build failed, but I'm going to merge this anyway and see what happens. I think it may have been a fluke.

[chkal]

Hmmm. Looks like the CDI tests now pass on Wildfly but fail on TomEE :)

[BrynCooke]

I couldn't see from Travis why this was failing on TomEE, I think the logs are tuncated?

[chkal]

There is a "download logs" link on the upper right side.

Here are the raw logs:

https://s3.amazonaws.com/archive.travis-ci.org/jobs/12997362/log.txt

[lincolnthree]

It looks like the CDI integration tests now fail to deploy on TomEE. That's
the reason. Not sure the root cause of that.

On Thu, Oct 24, 2013 at 2:27 PM, Christian Kaltepoth <
notifications@github.com> wrote:

There is a "download logs" link on the upper right side.

Here are the raw logs:

https://s3.amazonaws.com/archive.travis-ci.org/jobs/12997362/log.txt

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/143#issuecomment-27017416
.

Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."

[BrynCooke]

On my local machine rolling back to before my change and running the build with:
export CONTAINER=TOMEE_MANAGED_1.5
produces the same errors

[BrynCooke]

But I need to have a deployable container on the classpath... So it could still be my changes

[BrynCooke]

I think the TomEE issue is unrelated to this change:
git checkout a0ef442
mvn clean test -PTOMEE_MANAGED_1.5

Gives me

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.792 sec <<< FAILURE! - in org.ocpsoft.rewrite.cdi.bridge.CdiMultipleFeaturesTest
org.ocpsoft.rewrite.cdi.bridge.CdiMultipleFeaturesTest Time elapsed: 3.792 sec <<< ERROR!
org.jboss.arquillian.container.spi.client.container.DeploymentException: Unable to deploy

[chkal]

Hmmm. Weird. The tests were fine before we merged the pull request:

https://travis-ci.org/ocpsoft/rewrite/builds

However, I think your patch is fine. If there are problems with TomEE, they will either be unrelated to you patch or they are caused by a bug in OpenWebBeans.

I'll try to find some time tomorrow to have a deeper look.

[chkal]

I just checked what is going wrong with the TomEE builds. The tests were fine with:

actualTypeParameters[i] = Object.class;

But they broke after changing it to:

actualTypeParameters[i] = new WildcardTypeImpl(new Type[]{}, new Type[]{});

The cause seems to be an ArrayIndexOutOfBoundsException in the OpenWebBeans code. Changing it like this seems to fix the issue.

actualTypeParameters[i] = new WildcardTypeImpl(new Type[]{Object.class}, new Type[]{});

I pushed the change out:

6f3578d

Let's wait for Travis to tell us if this works on the other containers. :)

[chkal]

I just reported this issue:

https://issues.apache.org/jira/browse/OWB-907

[chkal]

The tests are green:

https://travis-ci.org/ocpsoft/rewrite

Thanks again for helping us with this. :)

[lincolnthree]

Yeah! Seriously! Thanks a lot for researching this fix! We really
appreciate it, and we'll get a new release out for you soon :) Join our
mailing list to get notifications of this! http://ocpsoft.org/subscribe/

On Fri, Oct 25, 2013 at 2:24 AM, Christian Kaltepoth <
notifications@github.com> wrote:

The tests are green:

https://travis-ci.org/ocpsoft/rewrite

Thanks again for helping us with this. :)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/143#issuecomment-27068218
.

Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."