Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused function select_regions() in ocropus-nlbin #137

Open
amitdo opened this issue Nov 1, 2016 · 2 comments
Open

Unused function select_regions() in ocropus-nlbin #137

amitdo opened this issue Nov 1, 2016 · 2 comments

Comments

@amitdo
Copy link
Contributor

@amitdo amitdo commented Nov 1, 2016

def select_regions(binary,f,min=0,nbest=100000)

Robust Binarization of Stereo and Monocular Document Images Using Percentile Filter
In this paper, there is a text area detection phase (figure 2f).

@zuphilip
Copy link
Collaborator

@zuphilip zuphilip commented Jan 2, 2017

It looks that the function select_regions is defined two times:

The second one is also used in ocropus-gpageseg, see https://github.com/tmbdev/ocropy/search?utf8=%E2%9C%93&q=select_regions .

What would you suggest to do?

@amitdo
Copy link
Contributor Author

@amitdo amitdo commented Jan 6, 2017

Hi Philipp!

Assuming the two select_regions are identical, you can remove the one in ocropus-nlbin.

To solve the original issue I reported, in ocropus-nlbin you should import morph and call the function somewhere.

zuphilip added a commit that referenced this issue Feb 5, 2017
* see also #137
* the other two lines contained strange symbols coded as FF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Cleanup work
Ideas to discuss
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants