Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many changes aiming at reducing the size of request data #233

Merged
merged 10 commits into from Jan 21, 2016
Merged

Conversation

@vouillon
Copy link
Member

@vouillon vouillon commented Jan 19, 2016

No description provided.

Drup
Copy link
Member

Drup commented on b2612ae Jan 19, 2016

Can't you just .. not add it ? Put it somewhere server-side only instead ?

vouillon
Copy link
Member

vouillon commented on b2612ae Jan 19, 2016

I don't know how to do that. It is used in the shared file eliom_service_base.shared.ml.

@Drup
Copy link
Member

@Drup Drup commented Jan 19, 2016

I was looking at the client/server syntax "runtime" last week, and I was making myself familiar with it before doing a big cleanup. This is very welcome, I don't have to do the clean up anymore! :D

Give me tomorrow to look at it in more details, so that I can convince myself we are not breaking anything (especially the revised implementation of client values).

Please add some comments for implementation decisions.

@Drup Drup added this to the 5.0 milestone Jan 19, 2016
@Drup
Copy link
Member

@Drup Drup commented Jan 19, 2016

@vouillon Did you measure the improvements ? Can you give us an idea ?

@vouillon
Copy link
Member Author

@vouillon vouillon commented Jan 19, 2016

For the Besport landing page, the uncompressed size of the request data goes from 130k to 78k (40% lower), and the compressed size from 24755 bytes down to 17059 bytes (30% lower).

vouillon added 4 commits Jan 21, 2016
In several places, I had to use type poly for values of type
client_value, as the type is not available yet (the correct type is put
in comments). It does not seem possible to fix that without heavy
refactoring of the code.
@vouillon
Copy link
Member Author

@vouillon vouillon commented Jan 21, 2016

I added some comments.

Drup added a commit that referenced this issue Jan 21, 2016
Many changes aiming at reducing the size of request data
@Drup Drup merged commit eb3da40 into master Jan 21, 2016
1 check passed
@Drup Drup deleted the request-data branch Jan 21, 2016
@Drup
Copy link
Member

@Drup Drup commented Jan 21, 2016

@vouillon You are using bytes apparently, which doesn't exist in old ocaml. We will need to use base-bytes and modify this a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants