Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export reraise, document recommended use #963

Merged
merged 4 commits into from
Oct 28, 2022

Conversation

raphael-proust
Copy link
Collaborator

Better backtrace management primitive and recommendations.

On a dummy example, I manage to obtain accurate backtrace information. Will test on more realistic examples as well.

@raphael-proust
Copy link
Collaborator Author

Following the recommendations of this MR, we get backtraces which are quite close to the ppx equivalent. There is still a little bit more noise in the form of additional occurrences of Lwt.Miscellaneous.poll than the ppx. But all the information from the ppx is also represent in the reraise backtraces.

A minor difference is that the "Re-raised" entries have the location of the reraise, whereas with the ppx they have the location of the try%lwt.

(Of course, the ppx is still useful for accessing all the additional keywords like while%lwt and such.)

@raphael-proust raphael-proust force-pushed the export-reraise-and-update-recommendations branch from 7749826 to 242e2f7 Compare October 27, 2022 09:48
@raphael-proust raphael-proust merged commit 5907991 into master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant