Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New interfaces #63

Merged
merged 13 commits into from Apr 14, 2015

Conversation

@Drup
Copy link
Member

commented Apr 2, 2015

A set of new interfaces, preliminary to the cohttp patch (but independent of cohttp).

I have not yet review in details, only shuffled until it was in an acceptable shape. Will probably keep shuffling. It builds and launches.

At least, I'm getting good at cherry-picking.

@Drup Drup referenced this pull request Apr 2, 2015

@Drup Drup force-pushed the new_interfaces branch 2 times, most recently from edce084 to be8f076 Apr 3, 2015

@Drup

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2015

Except for commit 620edf8, of which I'm not convinced it's actually useful. The rest seems perfectly fine to me.

@Drup Drup force-pushed the new_interfaces branch 2 times, most recently from b032731 to f9dba07 Apr 3, 2015

@Drup

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2015

I moved the commit about Ocsigen_Is_a_directory in this branch. Everything seems fine to me, it's almost only refactoring. The patch for eliom is on the cohttp branch.

@vouillon @balat ?

@Drup Drup force-pushed the new_interfaces branch from f735436 to cef83a6 Apr 4, 2015

@Drup Drup force-pushed the new_interfaces branch from cef83a6 to 9260404 Apr 5, 2015

@Drup Drup force-pushed the new_interfaces branch from 99d9797 to 122129b Apr 8, 2015

@Drup

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2015

@vouillon I removed the cohttp mention in the documentation Makefile. Merge when you feel like it.

vouillon added a commit that referenced this pull request Apr 14, 2015

@vouillon vouillon merged commit 6668a7b into master Apr 14, 2015

1 check passed

default Merged build finished.
Details

@Drup Drup deleted the new_interfaces branch Apr 14, 2015

@Drup

This comment has been minimized.

Copy link
Member Author

commented Apr 14, 2015

This patch breaks ocaml 3.12 because of the -bin-annot option, but cohttp is ocaml >= 4.01 only, so I guess we ca remove it anyway ?

@vasilisp vasilisp referenced this pull request Jun 14, 2017
0 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.