Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollMouse doesn't work on Windows XP. #97

Closed
octalmage opened this issue Oct 4, 2015 · 4 comments
Closed

scrollMouse doesn't work on Windows XP. #97

octalmage opened this issue Oct 4, 2015 · 4 comments
Labels
Milestone

Comments

@octalmage
Copy link
Owner

See #50. I commented the code out in 062be3f until we can figure it out.

cc: @Deltatiger

@octalmage octalmage modified the milestone: First Stable Release. Oct 18, 2015
@ghost
Copy link

ghost commented Feb 1, 2016

I was able to reproduce your errors in #50 on Windows 10.

The problem is VS2008 (or more specific C89), which requires variables to be declared at the beginning of a scope. Newer versions of VS have better support for C99, with ex. better variable declarations.

I could resolve this by putting the declaration of mouseScrollInput at the beginning of the scrollMouse function, alternative you could also wrap the Windows-elif in an enclosing {} block.

@octalmage
Copy link
Owner Author

@verth Thanks for looking into this! Could you submit a pull request? I'm fine with moving the variables to the top of the function.

@ghost
Copy link

ghost commented Feb 17, 2016

Yes, I will! Wasn't too sure what you would prefer. Will look to do it today or tomorrow.

octalmage added a commit that referenced this issue Feb 18, 2016
fix for #97, mouseScroll Windows XP
@octalmage
Copy link
Owner Author

This was resolved by #163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant