Compilation for Linux #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! I'll confirm it still works on Mac, then merge it! |
|
Everything looks good! COMMENCING MERGE. |
|
Thanks again for your help, I'll make sure to thank you in the readme! Now I just need to figure out the Windows builds, I think I might turn to the node-gyp team. autopy builds without issue, so it's just a matter of getting the flags right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks the start you provided in #17 - I did some investigation on my machine and got the simple mouse example working with some tweaks (I went a little overboard - sorry) to the binding.gyp file. Hopefully it all still works on MacOS :)