New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overriding platform in composer.json #4181
Comments
@czerwonyd take a look at the @daftspunk comment f12f3af |
Oh you're right, I have missed it. But still I think, the PHP 7.0 compatibility is no longer needed when it's support has ended, don't you think? |
I might agree with you or not, but I understand why @daftspunk freeze version because there would be even more issues related to dep hell (.dll). |
@w20k Does that mean one cannot create a marketplace plugin with a package dependency that requires PHP 7.1? That would be problematic as more and more packages make 7.1 a minimum requirement as 7.0 is EOL. |
@frthjf pretty much, OCMS has it's own rules. When new LTS version will come to Laravel we will switch, I guess. |
@frthjf It is problematic especially for users of our plugins. I have added a note in documentation of my plugin and link to this issue so that more technical users can understand why installation of our plugin does not work. |
@czerwonyd Thanks, does that mean that I can publish through the marketplace but the users will have to modify their composer.json? Also, what happens if there is no composer.json because you used the wizard? |
@frthjf I probably have not tested all the possibilities, but generally speaking, yes - it will work for both of cases as long as you have the required PHP version installed of course. |
Description:
While installing packages that requires PHP >=7.1 the installation fails, because of
in
composer.json
.Example package: Brick/Money.
Despite the installation I guess PHP 7.0 should not be used any longer since it's support has ended in the January 2019.
The text was updated successfully, but these errors were encountered: