Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding platform in composer.json #4181

Closed
tomaszstrojny opened this issue Mar 4, 2019 · 8 comments
Closed

Overriding platform in composer.json #4181

tomaszstrojny opened this issue Mar 4, 2019 · 8 comments

Comments

@tomaszstrojny
Copy link
Contributor

  • OctoberCMS Build: 440 - 448
  • PHP Version: >=7.1

Description:

While installing packages that requires PHP >=7.1 the installation fails, because of

    "config": {
        "preferred-install": "dist",
        "platform": {
            "php": "7.0"
        }
    },

in composer.json.

Example package: Brick/Money.

Despite the installation I guess PHP 7.0 should not be used any longer since it's support has ended in the January 2019.

@w20k
Copy link
Contributor

w20k commented Mar 4, 2019

@czerwonyd take a look at the @daftspunk comment f12f3af

@tomaszstrojny
Copy link
Contributor Author

Oh you're right, I have missed it. But still I think, the PHP 7.0 compatibility is no longer needed when it's support has ended, don't you think?

@w20k
Copy link
Contributor

w20k commented Mar 4, 2019

I might agree with you or not, but I understand why @daftspunk freeze version because there would be even more issues related to dep hell (.dll).

@w20k w20k closed this as completed Mar 4, 2019
@frthjf
Copy link

frthjf commented Mar 9, 2019

@w20k Does that mean one cannot create a marketplace plugin with a package dependency that requires PHP 7.1? That would be problematic as more and more packages make 7.1 a minimum requirement as 7.0 is EOL.

@w20k
Copy link
Contributor

w20k commented Mar 11, 2019

@frthjf pretty much, OCMS has it's own rules. When new LTS version will come to Laravel we will switch, I guess.

@tomaszstrojny
Copy link
Contributor Author

@frthjf It is problematic especially for users of our plugins. I have added a note in documentation of my plugin and link to this issue so that more technical users can understand why installation of our plugin does not work.

@frthjf
Copy link

frthjf commented Mar 11, 2019

@czerwonyd Thanks, does that mean that I can publish through the marketplace but the users will have to modify their composer.json? Also, what happens if there is no composer.json because you used the wizard?

@tomaszstrojny
Copy link
Contributor Author

@frthjf I probably have not tested all the possibilities, but generally speaking, yes - it will work for both of cases as long as you have the required PHP version installed of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants