New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on PHP 7.3 #4023

Merged
merged 1 commit into from Dec 30, 2018

Conversation

Projects
None yet
3 participants
@andreybolonin
Copy link

andreybolonin commented Dec 30, 2018

No description provided.

@LukeTowers

This comment has been minimized.

Copy link
Member

LukeTowers commented Dec 30, 2018

@w20k when you're back can you update octobercms/library, rainlab/user-plugin (and any other rainlab/october repos we use travis on) to include 7.3 too?

@LukeTowers

This comment has been minimized.

Copy link
Member

LukeTowers commented Dec 30, 2018

This pull request has been made to the wrong branch. Please review the contributing guidelines as all PRs need to be made to the develop branch.

I'll fix it for you this time, but please ensure you make any future PRs to the develop branch, not the master branch.

@LukeTowers LukeTowers changed the base branch from master to develop Dec 30, 2018

@LukeTowers LukeTowers changed the title Update .travis.yml Run tests on PHP 7.3 Dec 30, 2018

@LukeTowers LukeTowers merged commit e5dbcc4 into octobercms:develop Dec 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@w20k

This comment has been minimized.

Copy link
Contributor

w20k commented Jan 7, 2019

@LukeTowers - done. Though newline was added via github editor. Ping me if better to remove it 😉

bennothommo added a commit to bennothommo/october that referenced this pull request Feb 1, 2019

Rike-cz added a commit to Rike-cz/october that referenced this pull request Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment