New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octobox issue view doesn't redirect to github when "Open" button is clicked #1336

Open
evexoio opened this Issue Dec 5, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@evexoio
Contributor

evexoio commented Dec 5, 2018

"Open" button in top of Octobox's issue view doesn't send to github issue url when "open" button is clicked.

Are you experiencing this issue in octobox.io or your own instance?

  • octobox.io
  • My instance

馃悶 Problem
dec-05-2018 17-43-30

馃幆 Goal
Make "Open" Button send to github.

馃挕 Possible solutions
It might be a missing a tag with a href to the github issue or something

@evexoio

This comment has been minimized.

Contributor

evexoio commented Dec 5, 2018

I think this is a design issue, its meant to show the status of the thread instead of sending to the actual thread on github.com

Something should be made on the design side. a button is not a good idea to show a state.

evexoio added a commit to evexoio/octobox that referenced this issue Dec 5, 2018

@evexoio evexoio referenced a pull request that will close this issue Dec 5, 2018

Open

Better design for threads status #1341

@evexoio

This comment has been minimized.

Contributor

evexoio commented Dec 14, 2018

@andrew any updates 馃檱馃徎鈥嶁檪锔?

@andrew

This comment has been minimized.

Member

andrew commented Dec 17, 2018

@evexoio I checked out your PR, to me it feels like the whole thread headers should be clickable, trying to hit the external link target on mobile is tricky!

@andrew andrew added bug design labels Dec 17, 2018

@evexoio

This comment has been minimized.

Contributor

evexoio commented Dec 17, 2018

@andrew yea that sounds good. should we make the issue status be clickable and redirect to the thread link on github?

@andrew

This comment has been minimized.

Member

andrew commented Dec 17, 2018

馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment