New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing "ESC" on the search box could send the focus back to the list #1338

Closed
afilp opened this Issue Dec 5, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@afilp

afilp commented Dec 5, 2018

馃挜 Proposal

What feature you'd like to see

When pressing "ESC" on the search box the focus should go back to the list.

Motivation

This is related to this merged PR: #1322 (comment)

Pitch

This is whay many SAAS do. Thanks!

@evexoio

This comment has been minimized.

Contributor

evexoio commented Dec 5, 2018

Hey @afilp, I just tried to reproduce this use case and I couldn't. there was no issue with it at all.

@afilp

This comment has been minimized.

afilp commented Dec 5, 2018

While I am typing inside the search box, I may want to "cancel" and press "ESC" and just continue my navigation. Now "ESC" does not do anything while I am typing inside the Search Box.

@evexoio

This comment has been minimized.

Contributor

evexoio commented Dec 5, 2018

@afilp yep, I can reproduce now. thanks for insisting on pushing repro steps! 馃檶

I pushed a fix 馃憤

@andrew andrew closed this in #1342 Dec 7, 2018

andrew added a commit that referenced this issue Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment