Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread view doesn't show latest comment #1478

Open
akoeplinger opened this issue Jan 16, 2019 · 18 comments

Comments

Projects
None yet
3 participants
@akoeplinger
Copy link

commented Jan 16, 2019

Are you experiencing this issue in octobox.io or your own instance?

  • octobox.io
  • My instance

馃悶 Problem

The thread view isn't showing the latest comment that was made about an hour ago ago on this issue: https://github.com/mono/mono/issues/12422 (mapped to https://octobox.io/notifications/6061148 on Octobox).

It only shows the initial issue description and the "Reply on GitHub" button:

image

馃幆 Goal

The latest comment should be shown.

@andrew andrew added the bug label Jan 16, 2019

@andrew

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

@akoeplinger there's an issue at the moment with some data coming from the GitHub API which contains null byte characters which postgres refuses to save, this seems to happen more often on issues opened/commented on by windows users. I suspect this is the case here, will investigate.

null byte characters wasn't the issue here, still investigating

@andrew andrew self-assigned this Jan 16, 2019

@andrew andrew closed this Feb 7, 2019

@andrew andrew removed their assignment Feb 7, 2019

@andrew andrew reopened this Mar 3, 2019

@akoeplinger

This comment has been minimized.

Copy link
Author

commented Mar 4, 2019

Seeing this in e.g. https://github.com/mono/mono/pull/13215, it has multiple comments but octobox.io only shows this:

image

@andrew

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

That looks related to #1659 as the comment counter is in a similar state of nil rather than zero

@akoeplinger

This comment has been minimized.

Copy link
Author

commented Mar 4, 2019

The issue shows up after reloading Octobox too.

@akoeplinger

This comment has been minimized.

Copy link
Author

commented Mar 4, 2019

The PR I mentioned was merged and that caused the thread view to update and show the missing comments.

@andrew

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

@akoeplinger yeah, that's the same behaviour as seen in #1659, something appears to be setting comment_count to nil incorrectly which causes all comments and the comment form to get hidden

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019 — with Octobox

I'm still unsure what's causing this but I'll take another look this morning. If someone could help get it replicable that would be awesome.

@akoeplinger

This comment has been minimized.

Copy link
Author

commented Mar 5, 2019

I'm seeing this now on #1662, shows zero comments in Octobox but one on GitHub 馃槃

@akoeplinger

This comment has been minimized.

Copy link
Author

commented Mar 5, 2019

@BenJam I think I have a lead on this: I checked some webhook payloads of GitHub issues that show the problem and it seems the comments field sometimes doesn't contain the current comment in the count, i.e. the second comment on an issue still has "comments": 1.

Could this mess up the calculation?

@akoeplinger

This comment has been minimized.

Copy link
Author

commented Mar 5, 2019

I see this for example on mono/mono#13279 which shows up as having 1 comment in Octobox but it actually has two comments on GitHub (the thread view shows comments correctly in this case since I guess it has > 0 comments).

Payload logs

Note that the second comment has a "comments": 1

Issue creation

Headers
Request URL: https://hooks.slack.com/services/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
Request method: POST
content-type: application/json
Expect: 
User-Agent: GitHub-Hookshot/1174c8d
X-GitHub-Delivery: 57c67c70-3e12-11e9-845e-af0934b34497
X-GitHub-Event: issues
Payload
{
  "action": "opened",
  "issue": {
    "url": "https://api.github.com/repos/mono/mono/issues/13279",
    "repository_url": "https://api.github.com/repos/mono/mono",
    "labels_url": "https://api.github.com/repos/mono/mono/issues/13279/labels{/name}",
    "comments_url": "https://api.github.com/repos/mono/mono/issues/13279/comments",
    "events_url": "https://api.github.com/repos/mono/mono/issues/13279/events",
    "html_url": "https://github.com/mono/mono/issues/13279",
    "id": 416584794,
    "node_id": "MDU6SXNzdWU0MTY1ODQ3OTQ=",
    "number": 13279,
    "title": "mkbundle kills mailsending",
    "user": {
      "login": "j0shval3r0",
      "id": 29289461,
      "node_id": "MDQ6VXNlcjI5Mjg5NDYx",
      "avatar_url": "https://avatars2.githubusercontent.com/u/29289461?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/j0shval3r0",
      "html_url": "https://github.com/j0shval3r0",
      "followers_url": "https://api.github.com/users/j0shval3r0/followers",
      "following_url": "https://api.github.com/users/j0shval3r0/following{/other_user}",
      "gists_url": "https://api.github.com/users/j0shval3r0/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/j0shval3r0/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/j0shval3r0/subscriptions",
      "organizations_url": "https://api.github.com/users/j0shval3r0/orgs",
      "repos_url": "https://api.github.com/users/j0shval3r0/repos",
      "events_url": "https://api.github.com/users/j0shval3r0/events{/privacy}",
      "received_events_url": "https://api.github.com/users/j0shval3r0/received_events",
      "type": "User",
      "site_admin": false
    },
    "labels": [

    ],
    "state": "open",
    "locked": false,
    "assignee": null,
    "assignees": [

    ],
    "milestone": null,
    "comments": 0,
    "created_at": "2019-03-04T00:13:31Z",
    "updated_at": "2019-03-04T00:13:31Z",
    "closed_at": null,
    "author_association": "NONE",
    "body": "Hi!  I am writing an app with mono and it works fine.  Until I try to mkbundle it.\r\nMkbundle itself works fine.  But when I try and run the program after bundling I get this error:\r\n\r\nSystem.Net.Mail.SmtpException: Message could not be sent. ---> System.Security.Authentication.AuthenticationException: Authentication failed, see inner exception. ---> Mono.Btls.MonoBtlsException: Ssl error:1000007d:SSL routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED\r\n\r\nIf I add --env MONO_TLS_PROVIDER=legacy I get a different error\r\n\r\nSystem.Net.Mail.SmtpException: Message could not be sent. ---> System.IO.IOException: The authentication or decryption has failed. ---> System.IO.IOException: The authentication or decryption has failed. ---> Mono.Security.Protocol.Tls.TlsException: Invalid certificate received from server. Error code: 0xffffffff800b0109\r\n\r\nAgain, this program works fine.  It's only when I bundle the dlls (that have nothing to do with mailsending) with the program that this happens.  I am even using --nodeps.\r\n\r\nAny help is appreciated!  Thanks in advance!"
  },
  "repository": {
    "id": 791611,
    "node_id": "MDEwOlJlcG9zaXRvcnk3OTE2MTE=",
    "name": "mono",
    "full_name": "mono/mono",
    "private": false,
    "owner": {
      "login": "mono",
      "id": 53395,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjUzMzk1",
      "avatar_url": "https://avatars3.githubusercontent.com/u/53395?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/mono",
      "html_url": "https://github.com/mono",
      "followers_url": "https://api.github.com/users/mono/followers",
      "following_url": "https://api.github.com/users/mono/following{/other_user}",
      "gists_url": "https://api.github.com/users/mono/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/mono/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/mono/subscriptions",
      "organizations_url": "https://api.github.com/users/mono/orgs",
      "repos_url": "https://api.github.com/users/mono/repos",
      "events_url": "https://api.github.com/users/mono/events{/privacy}",
      "received_events_url": "https://api.github.com/users/mono/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "html_url": "https://github.com/mono/mono",
    "description": "Mono open source ECMA CLI, C# and .NET implementation.",
    "fork": false,
    "url": "https://api.github.com/repos/mono/mono",
    "forks_url": "https://api.github.com/repos/mono/mono/forks",
    "keys_url": "https://api.github.com/repos/mono/mono/keys{/key_id}",
    "collaborators_url": "https://api.github.com/repos/mono/mono/collaborators{/collaborator}",
    "teams_url": "https://api.github.com/repos/mono/mono/teams",
    "hooks_url": "https://api.github.com/repos/mono/mono/hooks",
    "issue_events_url": "https://api.github.com/repos/mono/mono/issues/events{/number}",
    "events_url": "https://api.github.com/repos/mono/mono/events",
    "assignees_url": "https://api.github.com/repos/mono/mono/assignees{/user}",
    "branches_url": "https://api.github.com/repos/mono/mono/branches{/branch}",
    "tags_url": "https://api.github.com/repos/mono/mono/tags",
    "blobs_url": "https://api.github.com/repos/mono/mono/git/blobs{/sha}",
    "git_tags_url": "https://api.github.com/repos/mono/mono/git/tags{/sha}",
    "git_refs_url": "https://api.github.com/repos/mono/mono/git/refs{/sha}",
    "trees_url": "https://api.github.com/repos/mono/mono/git/trees{/sha}",
    "statuses_url": "https://api.github.com/repos/mono/mono/statuses/{sha}",
    "languages_url": "https://api.github.com/repos/mono/mono/languages",
    "stargazers_url": "https://api.github.com/repos/mono/mono/stargazers",
    "contributors_url": "https://api.github.com/repos/mono/mono/contributors",
    "subscribers_url": "https://api.github.com/repos/mono/mono/subscribers",
    "subscription_url": "https://api.github.com/repos/mono/mono/subscription",
    "commits_url": "https://api.github.com/repos/mono/mono/commits{/sha}",
    "git_commits_url": "https://api.github.com/repos/mono/mono/git/commits{/sha}",
    "comments_url": "https://api.github.com/repos/mono/mono/comments{/number}",
    "issue_comment_url": "https://api.github.com/repos/mono/mono/issues/comments{/number}",
    "contents_url": "https://api.github.com/repos/mono/mono/contents/{+path}",
    "compare_url": "https://api.github.com/repos/mono/mono/compare/{base}...{head}",
    "merges_url": "https://api.github.com/repos/mono/mono/merges",
    "archive_url": "https://api.github.com/repos/mono/mono/{archive_format}{/ref}",
    "downloads_url": "https://api.github.com/repos/mono/mono/downloads",
    "issues_url": "https://api.github.com/repos/mono/mono/issues{/number}",
    "pulls_url": "https://api.github.com/repos/mono/mono/pulls{/number}",
    "milestones_url": "https://api.github.com/repos/mono/mono/milestones{/number}",
    "notifications_url": "https://api.github.com/repos/mono/mono/notifications{?since,all,participating}",
    "labels_url": "https://api.github.com/repos/mono/mono/labels{/name}",
    "releases_url": "https://api.github.com/repos/mono/mono/releases{/id}",
    "deployments_url": "https://api.github.com/repos/mono/mono/deployments",
    "created_at": "2010-07-22T18:06:36Z",
    "updated_at": "2019-03-03T16:01:07Z",
    "pushed_at": "2019-03-04T00:05:09Z",
    "git_url": "git://github.com/mono/mono.git",
    "ssh_url": "git@github.com:mono/mono.git",
    "clone_url": "https://github.com/mono/mono.git",
    "svn_url": "https://github.com/mono/mono",
    "homepage": "http://www.mono-project.com/",
    "size": 517097,
    "stargazers_count": 7503,
    "watchers_count": 7503,
    "language": "C#",
    "has_issues": true,
    "has_projects": true,
    "has_downloads": false,
    "has_wiki": true,
    "has_pages": false,
    "forks_count": 3092,
    "mirror_url": null,
    "archived": false,
    "open_issues_count": 1074,
    "license": {
      "key": "other",
      "name": "Other",
      "spdx_id": "NOASSERTION",
      "url": null,
      "node_id": "MDc6TGljZW5zZTA="
    },
    "forks": 3092,
    "open_issues": 1074,
    "watchers": 7503,
    "default_branch": "master"
  },
  "organization": {
    "login": "mono",
    "id": 53395,
    "node_id": "MDEyOk9yZ2FuaXphdGlvbjUzMzk1",
    "url": "https://api.github.com/orgs/mono",
    "repos_url": "https://api.github.com/orgs/mono/repos",
    "events_url": "https://api.github.com/orgs/mono/events",
    "hooks_url": "https://api.github.com/orgs/mono/hooks",
    "issues_url": "https://api.github.com/orgs/mono/issues",
    "members_url": "https://api.github.com/orgs/mono/members{/member}",
    "public_members_url": "https://api.github.com/orgs/mono/public_members{/member}",
    "avatar_url": "https://avatars3.githubusercontent.com/u/53395?v=4",
    "description": null
  },
  "sender": {
    "login": "j0shval3r0",
    "id": 29289461,
    "node_id": "MDQ6VXNlcjI5Mjg5NDYx",
    "avatar_url": "https://avatars2.githubusercontent.com/u/29289461?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/j0shval3r0",
    "html_url": "https://github.com/j0shval3r0",
    "followers_url": "https://api.github.com/users/j0shval3r0/followers",
    "following_url": "https://api.github.com/users/j0shval3r0/following{/other_user}",
    "gists_url": "https://api.github.com/users/j0shval3r0/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/j0shval3r0/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/j0shval3r0/subscriptions",
    "organizations_url": "https://api.github.com/users/j0shval3r0/orgs",
    "repos_url": "https://api.github.com/users/j0shval3r0/repos",
    "events_url": "https://api.github.com/users/j0shval3r0/events{/privacy}",
    "received_events_url": "https://api.github.com/users/j0shval3r0/received_events",
    "type": "User",
    "site_admin": false
  }
}

First comment

Headers
Request URL: https://hooks.slack.com/services/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
Request method: POST
content-type: application/json
Expect: 
User-Agent: GitHub-Hookshot/1174c8d
X-GitHub-Delivery: 2c2540a0-3e77-11e9-97e5-ee046f7819c4
X-GitHub-Event: issue_comment
Payload
{
  "action": "created",
  "issue": {
    "url": "https://api.github.com/repos/mono/mono/issues/13279",
    "repository_url": "https://api.github.com/repos/mono/mono",
    "labels_url": "https://api.github.com/repos/mono/mono/issues/13279/labels{/name}",
    "comments_url": "https://api.github.com/repos/mono/mono/issues/13279/comments",
    "events_url": "https://api.github.com/repos/mono/mono/issues/13279/events",
    "html_url": "https://github.com/mono/mono/issues/13279",
    "id": 416584794,
    "node_id": "MDU6SXNzdWU0MTY1ODQ3OTQ=",
    "number": 13279,
    "title": "mkbundle kills mailsending",
    "user": {
      "login": "j0shval3r0",
      "id": 29289461,
      "node_id": "MDQ6VXNlcjI5Mjg5NDYx",
      "avatar_url": "https://avatars2.githubusercontent.com/u/29289461?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/j0shval3r0",
      "html_url": "https://github.com/j0shval3r0",
      "followers_url": "https://api.github.com/users/j0shval3r0/followers",
      "following_url": "https://api.github.com/users/j0shval3r0/following{/other_user}",
      "gists_url": "https://api.github.com/users/j0shval3r0/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/j0shval3r0/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/j0shval3r0/subscriptions",
      "organizations_url": "https://api.github.com/users/j0shval3r0/orgs",
      "repos_url": "https://api.github.com/users/j0shval3r0/repos",
      "events_url": "https://api.github.com/users/j0shval3r0/events{/privacy}",
      "received_events_url": "https://api.github.com/users/j0shval3r0/received_events",
      "type": "User",
      "site_admin": false
    },
    "labels": [
      {
        "id": 776718052,
        "node_id": "MDU6TGFiZWw3NzY3MTgwNTI=",
        "url": "https://api.github.com/repos/mono/mono/labels/question",
        "name": "question",
        "color": "0e8a16",
        "default": true
      }
    ],
    "state": "open",
    "locked": false,
    "assignee": null,
    "assignees": [

    ],
    "milestone": null,
    "comments": 1,
    "created_at": "2019-03-04T00:13:31Z",
    "updated_at": "2019-03-04T12:15:17Z",
    "closed_at": null,
    "author_association": "NONE",
    "body": "Hi!  I am writing an app with mono and it works fine.  Until I try to mkbundle it.\r\nMkbundle itself works fine.  But when I try and run the program after bundling I get this error:\r\n\r\nSystem.Net.Mail.SmtpException: Message could not be sent. ---> System.Security.Authentication.AuthenticationException: Authentication failed, see inner exception. ---> Mono.Btls.MonoBtlsException: Ssl error:1000007d:SSL routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED\r\n\r\nIf I add --env MONO_TLS_PROVIDER=legacy I get a different error\r\n\r\nSystem.Net.Mail.SmtpException: Message could not be sent. ---> System.IO.IOException: The authentication or decryption has failed. ---> System.IO.IOException: The authentication or decryption has failed. ---> Mono.Security.Protocol.Tls.TlsException: Invalid certificate received from server. Error code: 0xffffffff800b0109\r\n\r\nAgain, this program works fine.  It's only when I bundle the dlls (that have nothing to do with mailsending) with the program that this happens.  I am even using --nodeps.\r\n\r\nAny help is appreciated!  Thanks in advance!"
  },
  "comment": {
    "url": "https://api.github.com/repos/mono/mono/issues/comments/469231695",
    "html_url": "https://github.com/mono/mono/issues/13279#issuecomment-469231695",
    "issue_url": "https://api.github.com/repos/mono/mono/issues/13279",
    "id": 469231695,
    "node_id": "MDEyOklzc3VlQ29tbWVudDQ2OTIzMTY5NQ==",
    "user": {
      "login": "marek-safar",
      "id": 250852,
      "node_id": "MDQ6VXNlcjI1MDg1Mg==",
      "avatar_url": "https://avatars1.githubusercontent.com/u/250852?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/marek-safar",
      "html_url": "https://github.com/marek-safar",
      "followers_url": "https://api.github.com/users/marek-safar/followers",
      "following_url": "https://api.github.com/users/marek-safar/following{/other_user}",
      "gists_url": "https://api.github.com/users/marek-safar/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/marek-safar/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/marek-safar/subscriptions",
      "organizations_url": "https://api.github.com/users/marek-safar/orgs",
      "repos_url": "https://api.github.com/users/marek-safar/repos",
      "events_url": "https://api.github.com/users/marek-safar/events{/privacy}",
      "received_events_url": "https://api.github.com/users/marek-safar/received_events",
      "type": "User",
      "site_admin": false
    },
    "created_at": "2019-03-04T12:15:17Z",
    "updated_at": "2019-03-04T12:15:17Z",
    "author_association": "MEMBER",
    "body": "/cc @baulig "
  },
  "repository": {
    "id": 791611,
    "node_id": "MDEwOlJlcG9zaXRvcnk3OTE2MTE=",
    "name": "mono",
    "full_name": "mono/mono",
    "private": false,
    "owner": {
      "login": "mono",
      "id": 53395,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjUzMzk1",
      "avatar_url": "https://avatars3.githubusercontent.com/u/53395?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/mono",
      "html_url": "https://github.com/mono",
      "followers_url": "https://api.github.com/users/mono/followers",
      "following_url": "https://api.github.com/users/mono/following{/other_user}",
      "gists_url": "https://api.github.com/users/mono/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/mono/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/mono/subscriptions",
      "organizations_url": "https://api.github.com/users/mono/orgs",
      "repos_url": "https://api.github.com/users/mono/repos",
      "events_url": "https://api.github.com/users/mono/events{/privacy}",
      "received_events_url": "https://api.github.com/users/mono/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "html_url": "https://github.com/mono/mono",
    "description": "Mono open source ECMA CLI, C# and .NET implementation.",
    "fork": false,
    "url": "https://api.github.com/repos/mono/mono",
    "forks_url": "https://api.github.com/repos/mono/mono/forks",
    "keys_url": "https://api.github.com/repos/mono/mono/keys{/key_id}",
    "collaborators_url": "https://api.github.com/repos/mono/mono/collaborators{/collaborator}",
    "teams_url": "https://api.github.com/repos/mono/mono/teams",
    "hooks_url": "https://api.github.com/repos/mono/mono/hooks",
    "issue_events_url": "https://api.github.com/repos/mono/mono/issues/events{/number}",
    "events_url": "https://api.github.com/repos/mono/mono/events",
    "assignees_url": "https://api.github.com/repos/mono/mono/assignees{/user}",
    "branches_url": "https://api.github.com/repos/mono/mono/branches{/branch}",
    "tags_url": "https://api.github.com/repos/mono/mono/tags",
    "blobs_url": "https://api.github.com/repos/mono/mono/git/blobs{/sha}",
    "git_tags_url": "https://api.github.com/repos/mono/mono/git/tags{/sha}",
    "git_refs_url": "https://api.github.com/repos/mono/mono/git/refs{/sha}",
    "trees_url": "https://api.github.com/repos/mono/mono/git/trees{/sha}",
    "statuses_url": "https://api.github.com/repos/mono/mono/statuses/{sha}",
    "languages_url": "https://api.github.com/repos/mono/mono/languages",
    "stargazers_url": "https://api.github.com/repos/mono/mono/stargazers",
    "contributors_url": "https://api.github.com/repos/mono/mono/contributors",
    "subscribers_url": "https://api.github.com/repos/mono/mono/subscribers",
    "subscription_url": "https://api.github.com/repos/mono/mono/subscription",
    "commits_url": "https://api.github.com/repos/mono/mono/commits{/sha}",
    "git_commits_url": "https://api.github.com/repos/mono/mono/git/commits{/sha}",
    "comments_url": "https://api.github.com/repos/mono/mono/comments{/number}",
    "issue_comment_url": "https://api.github.com/repos/mono/mono/issues/comments{/number}",
    "contents_url": "https://api.github.com/repos/mono/mono/contents/{+path}",
    "compare_url": "https://api.github.com/repos/mono/mono/compare/{base}...{head}",
    "merges_url": "https://api.github.com/repos/mono/mono/merges",
    "archive_url": "https://api.github.com/repos/mono/mono/{archive_format}{/ref}",
    "downloads_url": "https://api.github.com/repos/mono/mono/downloads",
    "issues_url": "https://api.github.com/repos/mono/mono/issues{/number}",
    "pulls_url": "https://api.github.com/repos/mono/mono/pulls{/number}",
    "milestones_url": "https://api.github.com/repos/mono/mono/milestones{/number}",
    "notifications_url": "https://api.github.com/repos/mono/mono/notifications{?since,all,participating}",
    "labels_url": "https://api.github.com/repos/mono/mono/labels{/name}",
    "releases_url": "https://api.github.com/repos/mono/mono/releases{/id}",
    "deployments_url": "https://api.github.com/repos/mono/mono/deployments",
    "created_at": "2010-07-22T18:06:36Z",
    "updated_at": "2019-03-04T11:58:29Z",
    "pushed_at": "2019-03-04T12:03:04Z",
    "git_url": "git://github.com/mono/mono.git",
    "ssh_url": "git@github.com:mono/mono.git",
    "clone_url": "https://github.com/mono/mono.git",
    "svn_url": "https://github.com/mono/mono",
    "homepage": "http://www.mono-project.com/",
    "size": 517137,
    "stargazers_count": 7507,
    "watchers_count": 7507,
    "language": "C#",
    "has_issues": true,
    "has_projects": true,
    "has_downloads": false,
    "has_wiki": true,
    "has_pages": false,
    "forks_count": 3090,
    "mirror_url": null,
    "archived": false,
    "open_issues_count": 1078,
    "license": {
      "key": "other",
      "name": "Other",
      "spdx_id": "NOASSERTION",
      "url": null,
      "node_id": "MDc6TGljZW5zZTA="
    },
    "forks": 3090,
    "open_issues": 1078,
    "watchers": 7507,
    "default_branch": "master"
  },
  "organization": {
    "login": "mono",
    "id": 53395,
    "node_id": "MDEyOk9yZ2FuaXphdGlvbjUzMzk1",
    "url": "https://api.github.com/orgs/mono",
    "repos_url": "https://api.github.com/orgs/mono/repos",
    "events_url": "https://api.github.com/orgs/mono/events",
    "hooks_url": "https://api.github.com/orgs/mono/hooks",
    "issues_url": "https://api.github.com/orgs/mono/issues",
    "members_url": "https://api.github.com/orgs/mono/members{/member}",
    "public_members_url": "https://api.github.com/orgs/mono/public_members{/member}",
    "avatar_url": "https://avatars3.githubusercontent.com/u/53395?v=4",
    "description": null
  },
  "sender": {
    "login": "marek-safar",
    "id": 250852,
    "node_id": "MDQ6VXNlcjI1MDg1Mg==",
    "avatar_url": "https://avatars1.githubusercontent.com/u/250852?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/marek-safar",
    "html_url": "https://github.com/marek-safar",
    "followers_url": "https://api.github.com/users/marek-safar/followers",
    "following_url": "https://api.github.com/users/marek-safar/following{/other_user}",
    "gists_url": "https://api.github.com/users/marek-safar/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/marek-safar/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/marek-safar/subscriptions",
    "organizations_url": "https://api.github.com/users/marek-safar/orgs",
    "repos_url": "https://api.github.com/users/marek-safar/repos",
    "events_url": "https://api.github.com/users/marek-safar/events{/privacy}",
    "received_events_url": "https://api.github.com/users/marek-safar/received_events",
    "type": "User",
    "site_admin": false
  }
}

Second comment

Headers
Request URL: https://hooks.slack.com/services/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
Request method: POST
content-type: application/json
Expect: 
User-Agent: GitHub-Hookshot/1174c8d
X-GitHub-Delivery: 4acfc420-3f04-11e9-8d9c-6ffd95c697d4
X-GitHub-Event: issue_comment
Payload
{
  "action": "created",
  "issue": {
    "url": "https://api.github.com/repos/mono/mono/issues/13279",
    "repository_url": "https://api.github.com/repos/mono/mono",
    "labels_url": "https://api.github.com/repos/mono/mono/issues/13279/labels{/name}",
    "comments_url": "https://api.github.com/repos/mono/mono/issues/13279/comments",
    "events_url": "https://api.github.com/repos/mono/mono/issues/13279/events",
    "html_url": "https://github.com/mono/mono/issues/13279",
    "id": 416584794,
    "node_id": "MDU6SXNzdWU0MTY1ODQ3OTQ=",
    "number": 13279,
    "title": "mkbundle kills mailsending",
    "user": {
      "login": "j0shval3r0",
      "id": 29289461,
      "node_id": "MDQ6VXNlcjI5Mjg5NDYx",
      "avatar_url": "https://avatars2.githubusercontent.com/u/29289461?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/j0shval3r0",
      "html_url": "https://github.com/j0shval3r0",
      "followers_url": "https://api.github.com/users/j0shval3r0/followers",
      "following_url": "https://api.github.com/users/j0shval3r0/following{/other_user}",
      "gists_url": "https://api.github.com/users/j0shval3r0/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/j0shval3r0/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/j0shval3r0/subscriptions",
      "organizations_url": "https://api.github.com/users/j0shval3r0/orgs",
      "repos_url": "https://api.github.com/users/j0shval3r0/repos",
      "events_url": "https://api.github.com/users/j0shval3r0/events{/privacy}",
      "received_events_url": "https://api.github.com/users/j0shval3r0/received_events",
      "type": "User",
      "site_admin": false
    },
    "labels": [
      {
        "id": 776718052,
        "node_id": "MDU6TGFiZWw3NzY3MTgwNTI=",
        "url": "https://api.github.com/repos/mono/mono/labels/question",
        "name": "question",
        "color": "0e8a16",
        "default": true
      }
    ],
    "state": "open",
    "locked": false,
    "assignee": null,
    "assignees": [

    ],
    "milestone": null,
    "comments": 1,
    "created_at": "2019-03-04T00:13:31Z",
    "updated_at": "2019-03-05T05:05:27Z",
    "closed_at": null,
    "author_association": "NONE",
    "body": "Hi!  I am writing an app with mono and it works fine.  Until I try to mkbundle it.\r\nMkbundle itself works fine.  But when I try and run the program after bundling I get this error:\r\n\r\nSystem.Net.Mail.SmtpException: Message could not be sent. ---> System.Security.Authentication.AuthenticationException: Authentication failed, see inner exception. ---> Mono.Btls.MonoBtlsException: Ssl error:1000007d:SSL routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED\r\n\r\nIf I add --env MONO_TLS_PROVIDER=legacy I get a different error\r\n\r\nSystem.Net.Mail.SmtpException: Message could not be sent. ---> System.IO.IOException: The authentication or decryption has failed. ---> System.IO.IOException: The authentication or decryption has failed. ---> Mono.Security.Protocol.Tls.TlsException: Invalid certificate received from server. Error code: 0xffffffff800b0109\r\n\r\nAgain, this program works fine.  It's only when I bundle the dlls (that have nothing to do with mailsending) with the program that this happens.  I am even using --nodeps.\r\n\r\nAny help is appreciated!  Thanks in advance!"
  },
  "comment": {
    "url": "https://api.github.com/repos/mono/mono/issues/comments/469539257",
    "html_url": "https://github.com/mono/mono/issues/13279#issuecomment-469539257",
    "issue_url": "https://api.github.com/repos/mono/mono/issues/13279",
    "id": 469539257,
    "node_id": "MDEyOklzc3VlQ29tbWVudDQ2OTUzOTI1Nw==",
    "user": {
      "login": "j0shval3r0",
      "id": 29289461,
      "node_id": "MDQ6VXNlcjI5Mjg5NDYx",
      "avatar_url": "https://avatars2.githubusercontent.com/u/29289461?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/j0shval3r0",
      "html_url": "https://github.com/j0shval3r0",
      "followers_url": "https://api.github.com/users/j0shval3r0/followers",
      "following_url": "https://api.github.com/users/j0shval3r0/following{/other_user}",
      "gists_url": "https://api.github.com/users/j0shval3r0/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/j0shval3r0/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/j0shval3r0/subscriptions",
      "organizations_url": "https://api.github.com/users/j0shval3r0/orgs",
      "repos_url": "https://api.github.com/users/j0shval3r0/repos",
      "events_url": "https://api.github.com/users/j0shval3r0/events{/privacy}",
      "received_events_url": "https://api.github.com/users/j0shval3r0/received_events",
      "type": "User",
      "site_admin": false
    },
    "created_at": "2019-03-05T05:05:27Z",
    "updated_at": "2019-03-05T05:05:27Z",
    "author_association": "NONE",
    "body": "Also please note that I have looked at\r\nhttps://www.mono-project.com/archived/usingtrustedrootsrespectfully/\r\nbut I don't want to put my user at a security risk, nor do I want to change the code (I have already had people review it, don't want to repeat this process).  I hope there is a way to fix this without changing the code, just through compiler options or something.\r\nThanks!"
  },
  "repository": {
    "id": 791611,
    "node_id": "MDEwOlJlcG9zaXRvcnk3OTE2MTE=",
    "name": "mono",
    "full_name": "mono/mono",
    "private": false,
    "owner": {
      "login": "mono",
      "id": 53395,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjUzMzk1",
      "avatar_url": "https://avatars3.githubusercontent.com/u/53395?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/mono",
      "html_url": "https://github.com/mono",
      "followers_url": "https://api.github.com/users/mono/followers",
      "following_url": "https://api.github.com/users/mono/following{/other_user}",
      "gists_url": "https://api.github.com/users/mono/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/mono/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/mono/subscriptions",
      "organizations_url": "https://api.github.com/users/mono/orgs",
      "repos_url": "https://api.github.com/users/mono/repos",
      "events_url": "https://api.github.com/users/mono/events{/privacy}",
      "received_events_url": "https://api.github.com/users/mono/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "html_url": "https://github.com/mono/mono",
    "description": "Mono open source ECMA CLI, C# and .NET implementation.",
    "fork": false,
    "url": "https://api.github.com/repos/mono/mono",
    "forks_url": "https://api.github.com/repos/mono/mono/forks",
    "keys_url": "https://api.github.com/repos/mono/mono/keys{/key_id}",
    "collaborators_url": "https://api.github.com/repos/mono/mono/collaborators{/collaborator}",
    "teams_url": "https://api.github.com/repos/mono/mono/teams",
    "hooks_url": "https://api.github.com/repos/mono/mono/hooks",
    "issue_events_url": "https://api.github.com/repos/mono/mono/issues/events{/number}",
    "events_url": "https://api.github.com/repos/mono/mono/events",
    "assignees_url": "https://api.github.com/repos/mono/mono/assignees{/user}",
    "branches_url": "https://api.github.com/repos/mono/mono/branches{/branch}",
    "tags_url": "https://api.github.com/repos/mono/mono/tags",
    "blobs_url": "https://api.github.com/repos/mono/mono/git/blobs{/sha}",
    "git_tags_url": "https://api.github.com/repos/mono/mono/git/tags{/sha}",
    "git_refs_url": "https://api.github.com/repos/mono/mono/git/refs{/sha}",
    "trees_url": "https://api.github.com/repos/mono/mono/git/trees{/sha}",
    "statuses_url": "https://api.github.com/repos/mono/mono/statuses/{sha}",
    "languages_url": "https://api.github.com/repos/mono/mono/languages",
    "stargazers_url": "https://api.github.com/repos/mono/mono/stargazers",
    "contributors_url": "https://api.github.com/repos/mono/mono/contributors",
    "subscribers_url": "https://api.github.com/repos/mono/mono/subscribers",
    "subscription_url": "https://api.github.com/repos/mono/mono/subscription",
    "commits_url": "https://api.github.com/repos/mono/mono/commits{/sha}",
    "git_commits_url": "https://api.github.com/repos/mono/mono/git/commits{/sha}",
    "comments_url": "https://api.github.com/repos/mono/mono/comments{/number}",
    "issue_comment_url": "https://api.github.com/repos/mono/mono/issues/comments{/number}",
    "contents_url": "https://api.github.com/repos/mono/mono/contents/{+path}",
    "compare_url": "https://api.github.com/repos/mono/mono/compare/{base}...{head}",
    "merges_url": "https://api.github.com/repos/mono/mono/merges",
    "archive_url": "https://api.github.com/repos/mono/mono/{archive_format}{/ref}",
    "downloads_url": "https://api.github.com/repos/mono/mono/downloads",
    "issues_url": "https://api.github.com/repos/mono/mono/issues{/number}",
    "pulls_url": "https://api.github.com/repos/mono/mono/pulls{/number}",
    "milestones_url": "https://api.github.com/repos/mono/mono/milestones{/number}",
    "notifications_url": "https://api.github.com/repos/mono/mono/notifications{?since,all,participating}",
    "labels_url": "https://api.github.com/repos/mono/mono/labels{/name}",
    "releases_url": "https://api.github.com/repos/mono/mono/releases{/id}",
    "deployments_url": "https://api.github.com/repos/mono/mono/deployments",
    "created_at": "2010-07-22T18:06:36Z",
    "updated_at": "2019-03-05T02:11:24Z",
    "pushed_at": "2019-03-05T04:05:03Z",
    "git_url": "git://github.com/mono/mono.git",
    "ssh_url": "git@github.com:mono/mono.git",
    "clone_url": "https://github.com/mono/mono.git",
    "svn_url": "https://github.com/mono/mono",
    "homepage": "http://www.mono-project.com/",
    "size": 517319,
    "stargazers_count": 7508,
    "watchers_count": 7508,
    "language": "C#",
    "has_issues": true,
    "has_projects": true,
    "has_downloads": false,
    "has_wiki": true,
    "has_pages": false,
    "forks_count": 3092,
    "mirror_url": null,
    "archived": false,
    "open_issues_count": 1071,
    "license": {
      "key": "other",
      "name": "Other",
      "spdx_id": "NOASSERTION",
      "url": null,
      "node_id": "MDc6TGljZW5zZTA="
    },
    "forks": 3092,
    "open_issues": 1071,
    "watchers": 7508,
    "default_branch": "master"
  },
  "organization": {
    "login": "mono",
    "id": 53395,
    "node_id": "MDEyOk9yZ2FuaXphdGlvbjUzMzk1",
    "url": "https://api.github.com/orgs/mono",
    "repos_url": "https://api.github.com/orgs/mono/repos",
    "events_url": "https://api.github.com/orgs/mono/events",
    "hooks_url": "https://api.github.com/orgs/mono/hooks",
    "issues_url": "https://api.github.com/orgs/mono/issues",
    "members_url": "https://api.github.com/orgs/mono/members{/member}",
    "public_members_url": "https://api.github.com/orgs/mono/public_members{/member}",
    "avatar_url": "https://avatars3.githubusercontent.com/u/53395?v=4",
    "description": null
  },
  "sender": {
    "login": "j0shval3r0",
    "id": 29289461,
    "node_id": "MDQ6VXNlcjI5Mjg5NDYx",
    "avatar_url": "https://avatars2.githubusercontent.com/u/29289461?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/j0shval3r0",
    "html_url": "https://github.com/j0shval3r0",
    "followers_url": "https://api.github.com/users/j0shval3r0/followers",
    "following_url": "https://api.github.com/users/j0shval3r0/following{/other_user}",
    "gists_url": "https://api.github.com/users/j0shval3r0/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/j0shval3r0/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/j0shval3r0/subscriptions",
    "organizations_url": "https://api.github.com/users/j0shval3r0/orgs",
    "repos_url": "https://api.github.com/users/j0shval3r0/repos",
    "events_url": "https://api.github.com/users/j0shval3r0/events{/privacy}",
    "received_events_url": "https://api.github.com/users/j0shval3r0/received_events",
    "type": "User",
    "site_admin": false
  }
}
@andrew

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

That could mess some things up, but I don鈥檛 think it will explain our comment count being set to null

@akoeplinger

This comment has been minimized.

Copy link
Author

commented Mar 5, 2019

Ah I see, subject.commentable is checking comment_count against nil. So the above mismatch is actually a different issue :)

@akoeplinger

This comment has been minimized.

Copy link
Author

commented Mar 5, 2019

Yeah it's indeed a different issue, but one that seems to occur more often than the nil issue.

When the mismatched comments count happens then I at least see the Leave a comment box in the thread view (since commentable is true).

Hit it again with https://github.com/mono/mono/issues/13298, the webhook payload shows "comments": 0 for the first comment on the issue.

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019 — with Octobox

Thanks for taking the time to help out on this @akoeplinger. I'm still not sure how to replicate it but would love to fix it 馃槙

@akoeplinger

This comment has been minimized.

Copy link
Author

commented Mar 5, 2019

I'm not sure you can do anything about the eventual consistency issue of the comments field other than not rely on it...

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019 — with Octobox

Fair point.

@akoeplinger

This comment has been minimized.

Copy link
Author

commented Mar 5, 2019

Might be worth contacting GitHub support to check whether this is expected/by design though.

@andrew

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

A fix for the comment count being set back to nil: #1760

Doesn't address the other issue reported here on an incorrect but non-nill count.

andrew added a commit that referenced this issue Apr 22, 2019

andrew added a commit that referenced this issue May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.