Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji in issue/PR view #1640

Open
bobheadxi opened this Issue Feb 26, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@bobheadxi
Copy link

bobheadxi commented Feb 26, 2019

馃挜 Proposal

What feature you'd like to see

It would be nice if the new open-in-octohub mode for issues and PRs supported emoji. Looks like it's already in labels #559, so hopefully this isn't too much?

Motivation

We use emoji a lot, and it looks rather bare without it rendered:

image

Pitch

馃挴 馃殌 馃檹

@andrew

This comment has been minimized.

Copy link
Member

andrew commented Feb 26, 2019

That's weird, emoji are showing correctly in this thread:

screenshot 2019-02-26 at 10 21 00

@andrew andrew added the bug label Feb 26, 2019

@andrew

This comment has been minimized.

Copy link
Member

andrew commented Feb 26, 2019

I suspect it's only the newer emojis that aren't working as gemoji hasn't been updated with all the new emojis that have come out in the past year: github/gemoji#139

@bobheadxi

This comment has been minimized.

Copy link
Author

bobheadxi commented Feb 26, 2019

馃 I'm not sure the emoji are that new - we've been using them since December 2017:

ubclaunchpad/inertia@10dfe94#diff-195a635ad245ded9076330e31134bd80

edit: on second thought, it appears that the new emoji mentioned in github/gemoji#139 might include these emojis (the timeframe kind of matches up)

edit again: construction_worker appears to be in Gemoji (and likewise with tickets and flashlight), so this might not be an issue on Gemoji's end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.