Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When posting a comment fails, can't post further comments #1659

Open
andrew opened this Issue Mar 4, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@andrew
Copy link
Member

andrew commented Mar 4, 2019

I tried to reply to a pull request with a comment from the threadview this morning and got an error flash message (not sure why), after that error, the comment field disappeared from the threadview for that PR.

screenshot 2019-03-04 at 08 25 25

The comment boxes still showed up on other pull requests from the same repository, so it must have been something that happened to that particular subject.

Also note that screenshot shows that the notification in question (top one) has null comment count, not zero or invisible, just the icon with no count, I suspect that something is changing the subject data when posting a comment fails.

The comment form and comment count came back the next time the subject was synced after I merged it from the GitHub UI.

@andrew andrew added the bug label Mar 4, 2019

@andrew andrew referenced this issue Mar 4, 2019

Open

Launch 'conversations' #1645

3 of 3 tasks complete
@BenJam

This comment has been minimized.

Copy link
Contributor

BenJam commented Mar 4, 2019

I'm gonna guess this is due to the comment counts not including the original subject body. So when we do comment.destroy at the end of the comments worker (when failing) it pulls that comment count.

Just a guess.

But yeah, the fact that it's set that comment count to something other than zero will remove the form as I think subject.commentable? will be false.

@BenJam

This comment has been minimized.

Copy link
Contributor

BenJam commented Mar 4, 2019

Just a guess.

nope ac27ffb

@andrew andrew referenced this issue Mar 4, 2019

Open

Thread view doesn't show latest comment #1478

1 of 2 tasks complete
@BenJam

This comment has been minimized.

Copy link
Contributor

BenJam commented Mar 5, 2019

got an error flash message (not sure why)

The only way this looks like it would happen would be if notifications_controller:138 flashed you.

It's possible that, between rendering the thread and posting something, #1478 is happening in the background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.