Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync PR review status #1731

Open
ahayworth opened this Issue Apr 8, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@ahayworth
Copy link

ahayworth commented Apr 8, 2019

馃挜 Proposal

What feature you'd like to see

Octobox could/should show me if a PR still needs a review, or if a review has been given (whether that review be a 馃憤, a 馃憥 , or just some comments).

Motivation

My team receives frequent review requests on multiple repositories. When using octobox to review outstanding work at the beginning of my day, I must open each PR individually on GitHub to see if a review request is still outstanding, or if it has been reviewed. This is a time sink. :)

Pitch

I believe this feature would benefit power users - like myself - who deal with many PRs daily. Knowing whether or not I still need to take action on a review would save me a great deal of time, and I suspect would save others a great deal of time as well. The information is available in the API, and as such seems somewhat straightforward to implement.

I believe this information can be ascertained from both the PR API and the PR Review API. I'm not 100% sure of the interplay there, but looking through a few PRs on a repo I watch I noticed a few things:

  • A PR that has reviews requested but not yet completed had items in the requested_users and/or requested_teams fields on the PR API response
    • This is also available in the review requests endpoint
  • PRs that had completed reviews (regardless of the status of those reviews) were found in the /reviews endpoint response

The graphql API may be easier to use here, since you could compose a single query that gets all required state.

@andrew

This comment has been minimized.

Copy link
Member

andrew commented Apr 8, 2019

@ahayworth do you know which permissions are needed to get that data from the GitHub api as a GitHub app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.