Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed comments #1791

Open
BenJam opened this issue Apr 30, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@BenJam
Copy link
Contributor

commented Apr 30, 2019

There's sometimes a delay between comments appearing on an issue/pr and their appearing on my octobox account. I've had reports of the same (some spanning hours) too:

Screenshot 2019-04-30 at 10 48 28

Screenshot 2019-04-30 at 10 48 23

Comment looks like it was left 18 hours ago, last sync on octobox was 5 minutes ago. I've got some time to investigate today, any ideas welcome @andrew.

@BenJam

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

Would like to address this before #1645 is completed.

@BenJam BenJam added the bug label Apr 30, 2019

@andrew

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@BenJam should be noted that my comment in the first screenshot is actually a pull request review comment, not a regular comment, I don't believe octobox will ever sync that one as we have no support for pull request review comments yet

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019 — with Octobox

Good point, i was quite sure I'd seen it before on an issue. I'll take a look at what it would take to add to a PR because I think it would be amiss not having that before launching conversations.

@BenJam

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

I don't believe octobox will ever sync that one as we have no support for pull request review comments yet

I still haven't got around to looking at this yet but: I can see all the PR comments for #1141 except the final one

image

I guess that review comments are different from general comments on the PR (which is actually just an issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.