Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use media accepts header to get github to render markdown of comment body #1800

Open
andrew opened this issue May 3, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@andrew
Copy link
Member

commented May 3, 2019

When downloading comment bodys from the github api, we can send a media query to request that github flavoured markdown is sent, that means we don't need to keep up with any extra features they add to their rendering engine: https://developer.github.com/v3/media/#comment-body-properties

@andrew andrew added the enhancement label May 6, 2019

@BenJam BenJam self-assigned this May 7, 2019

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019 — with Octobox

Bit confused: do you mean grabbing the html rather than raw?

@andrew

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

@BenJam yep 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.