Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

on hover, only change button of search tag #2254

Open
b3u opened this issue Feb 27, 2020 · 3 comments
Open

on hover, only change button of search tag #2254

b3u opened this issue Feb 27, 2020 · 3 comments

Comments

@b3u
Copy link

@b3u b3u commented Feb 27, 2020

馃挜 Proposal

What feature you'd like to see

When hovering on the selected search query, the current behavior is to change the color of the entire element. (See below)

Screenshot from 2020-02-27 12 34 34

I propose that only the button (the "x" over which the cursor appears in the image above) should produce an action, and not the rest of the element.

Motivation

I just found Octobox recently. This is one of the first things that annoyed me, so I decided to be useful with it 馃槈.

Pitch

  • The only action that the current search query element exposes is the button action (removing/clearing the query).
  • Ironically, I only realized that the "click area" extends past the "x" after I opened the issue. Originally, I assumed that the rest of the element did nothing.
  • In my mind, if clicking on the query itself had an action, the action would be to isolate that query and remove all other queries. (See below, where there are multiple queries)

image

@andrew

This comment has been minimized.

Copy link
Member

@andrew andrew commented Feb 27, 2020

Sounds like a nice little UX change, would you be interested in taking a stab at implementing it?

@b3u

This comment has been minimized.

Copy link
Author

@b3u b3u commented Feb 27, 2020

Sure! By the way, do you mind if I make a PR reorganizing the readme? IMHO it's pretty cluttered right now.

@andrew

This comment has been minimized.

Copy link
Member

@andrew andrew commented Feb 27, 2020

@b3u sure, that'd be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can鈥檛 perform that action at this time.