Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigating notifications via j / k doesn't scroll pane #3303

Open
1 of 2 tasks
aspiers opened this issue Apr 8, 2023 · 1 comment
Open
1 of 2 tasks

navigating notifications via j / k doesn't scroll pane #3303

aspiers opened this issue Apr 8, 2023 · 1 comment
Labels
bug Related to something that's working correctly design Visual and UX related items enhancement Improvements and features help wanted Contributions welcome JavaScript

Comments

@aspiers
Copy link
Contributor

aspiers commented Apr 8, 2023

Are you experiencing this issue in octobox.io or your own instance?

  • octobox.io
  • My instance

馃悶 Problem

When the list of notifications is longer than can fit in the browser window, navigating up and down the notifications via the j and k keyboard shortcuts can result in the selected item being off the bottom or top of the visible part of the list:

image

馃幆 Goal

When the selection moves outside the visible pane, the pane should automatically scroll to make the selected item visible.

馃挕 Possible solutions

The automatic scrolling could either scroll:

  • the minimum amount required to keep the selected item on the screen, requiring it to happen every time when scrolling continues in the same direction, or
  • the maximum amount (i.e. by a whole page, placing the selected item at the top of the pane if j was pressed, or at the bottom if k was pressed), requiring it to happen once per page of items, or
  • half a page, placing the selected item in the middle of the pane, and requiring it to happen approximately half as many times as full page scrolling.

The latter option has the advantage of showing items both above and below the now-centered selected item, so maybe that's the best option.

@andrew andrew added enhancement Improvements and features help wanted Contributions welcome design Visual and UX related items JavaScript bug Related to something that's working correctly labels Apr 10, 2023
@chrisdoherty4
Copy link

It would be great to get this feature.

I also had thoughts about an infinite scroll (which is somewhat orthogonal to this). The pagination feels less desirable when using hotkeys and felt myself wanting the screen to just load more as I moved through the notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Related to something that's working correctly design Visual and UX related items enhancement Improvements and features help wanted Contributions welcome JavaScript
Projects
None yet
Development

No branches or pull requests

3 participants