New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rack-mini-profiler and other performance gems #1345

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@tarebyte
Copy link
Member

tarebyte commented Dec 7, 2018

I was looking into an N+1 in our instance of Octobox and thought it'd be nice a nice addition for future use.

This adds the following gems

  • rack-mini-profiler
  • memory_profiler
  • flamegraph
  • stackprof

It also adds the pop up in the bottom right hand corner always in dev and for admins in production.

Thanks

tarebyte added some commits Dec 7, 2018

@tarebyte tarebyte requested review from andrew and jules2689 Dec 7, 2018

@andrew

This comment has been minimized.

Copy link
Member

andrew commented Dec 12, 2018

I'm reluctant to have these gems present all the time for all users when they are likely only to be used for infrequent performance tuning, the memory usage of sidekiq is already topping out the average heroku dyno as it is.

I wonder if we can keep it as a branch or option that can be deployed for performance investigation purposes?

@andrew

This comment has been minimized.

Copy link
Member

andrew commented Jan 15, 2019

Going to close this for now but will keep the branch around.

@andrew andrew closed this Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment