New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up thread views #1450

Merged
merged 29 commits into from Jan 15, 2019

Conversation

Projects
None yet
2 participants
@BenJam
Copy link
Contributor

BenJam commented Jan 11, 2019

Cleans and speed up some of the thread view, builds on #1449

@BenJam

This comment has been minimized.

Copy link
Contributor

BenJam commented Jan 11, 2019

alternative headers:

screenshot 2019-01-11 at 13 37 55

screenshot 2019-01-11 at 13 38 04

I prefer the later.

BenJam added some commits Jan 11, 2019

@andrew

This comment has been minimized.

Copy link
Member

andrew commented Jan 14, 2019

I also prefer the later 👌

@andrew

This comment has been minimized.

Copy link
Member

andrew commented Jan 14, 2019

@BenJam this appears to contain all the code from #1449, should this one be considered blocked until #1449 is merged or can we close #1449 instead?

@BenJam BenJam added the blocked label Jan 15, 2019

@BenJam

This comment has been minimized.

Copy link
Contributor

BenJam commented Jan 15, 2019

should this one be considered blocked until #1449 is merged or can we close #1449 instead?

^ this. Labelled as such.

@andrew andrew merged commit da1f0c9 into master Jan 15, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@andrew andrew deleted the thread-revamp branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment