Return empty array if skipping downloading reviews #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew
added a commit
that referenced
this pull request
Jul 22, 2019
* master: (40 commits) Bump fugit from 1.2.2 to 1.3.0 (#1947) Bump rake from 12.3.2 to 12.3.3 (#1946) wrap threads in card so that sticky header stays in place on mobile (#1944) Add draft state to the API (#1945) Round icons (#1943) Bump oj from 3.7.12 to 3.8.0 (#1942) Bump rubocop from 0.72.0 to 0.73.0 (#1941) Swallow internal server errors from Octokit when syncing review comments (#1939) Only download subjects for a notification if the user is present (#1937) Bump pagy from 3.3.2 to 3.4.0 (#1936) Allow custom port to be set for postgres OCTOBOX_DATABASE_PASSWORD (#1934) Bump hashdiff from 0.4.0 to 1.0.0 (#1935) Bump pg_search from 2.2.0 to 2.3.0 (#1932) Bump hirefire-resource from 0.7.1 to 0.7.2 (#1931) Bump get_process_mem from 0.2.3 to 0.2.4 (#1921) Bump bindex from 0.7.0 to 0.8.1 (#1923) Bump puma from 4.0.0 to 4.0.1 (#1930) Return empty array if skipping downloading reviews (#1928) Add the 'Organization members' permission for GitHub App (#1927) More nil checks before downloading reviews (#1926) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #1926