Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add ALLOW_HOSTNAME and ALLOW_ALL_HOSTNAMES environment variables #2013

Open
wants to merge 4 commits into
base: master
from

Conversation

@rhuss
Copy link
Contributor

commented Sep 8, 2019

This is to allow an octobox setup in an reverse proxy setup and to pass
the hostname check as described in https://www.fngtps.com/2019/rails6-blocked-host/

Also, adapted the OpenShift templates to use ALLOW_ALL_HOSTNAMES as
octobox is shielded by the OpenShift router anyway and does not require
this hostname check.

Fixes #2011.

fix: Add ALLOW_HOSTNAME and ALLOW_ALL_HOSTNAMES environment variables
This is to allow an octobox setup in an reverse proxy setup and to pass
the hostname check as described in https://www.fngtps.com/2019/rails6-blocked-host/

Also, adapted the OpenShift templates to use ALLOW_ALL_HOSTNAMES as
octobox is shielded by the OpenShift router anyway and does not require
this hostname check.

Fixes #2011.

@rhuss rhuss force-pushed the rhuss:pr/allow-hosts branch from 303ba8a to 5fbf76d Sep 9, 2019

@andrew
Copy link
Member

left a comment

Would be good to have a test for these changes

@rhuss

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

Sorry, but I have no idea how I should test this change. Tbh, I'm not a Ruby guy and although I probably could adapt an existing test case, for setting up a new test I would have to invest more time than I am currently able to spend.

'happy though to handover this PR to someone with more testing experience, as I think this is an important feature required for any setup with Octobox running behind a reverse proxy (like within a Kubernetes cluster with Ingress or in OpenShift, proxied through the OpenShift router).

The other change to the OpenShift template is also necessary to update to Redis 4 (which is the minimum Redis version now supported, was 3 before the latest changs).

sorry ...

@acidicX

This comment has been minimized.

Copy link

commented Sep 19, 2019

@andrew any news on this? The missing env is blocking Docker updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.