Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: Add ALLOW_HOSTNAME and ALLOW_ALL_HOSTNAMES environment variables #2013
This is to allow an octobox setup in an reverse proxy setup and to pass
Also, adapted the OpenShift templates to use ALLOW_ALL_HOSTNAMES as
Sorry, but I have no idea how I should test this change. Tbh, I'm not a Ruby guy and although I probably could adapt an existing test case, for setting up a new test I would have to invest more time than I am currently able to spend.
'happy though to handover this PR to someone with more testing experience, as I think this is an important feature required for any setup with Octobox running behind a reverse proxy (like within a Kubernetes cluster with Ingress or in OpenShift, proxied through the OpenShift router).
The other change to the OpenShift template is also necessary to update to Redis 4 (which is the minimum Redis version now supported, was 3 before the latest changs).