Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Distinguish pending self and team review requests #2028
Creating a superset of our own logic (even just a single thing) to further distinguish GitHub's vague reasons in the Notifications API - aka #1940 - didn't prove to be a good solution for seeing open review requests. There were many times things didn't line up. There are too many different moving parts to the state machine that is 'reasons' for a notification and ultimately the information contained there isn't as important as the actual current state of the subject....which leads us to here.
These changes sync requested reviewers (as #1940 did, but with team review requests as well) and focus on the state of the subject and not at all about the notification reason. This aligns much better with 1) How Octobox currently works for basically everything else and 2) GitHub, because we aren't interpreting any differing state fighting with the semantics of the Notifications API.
It's currently being tested at HashiCorp and we've had much, much better results this time around due to the simplicity of it.